Bug 169191 - Only use layer backing store which supports subpixel antialiased text if we know subpixel antialiased will be painted into it
Summary: Only use layer backing store which supports subpixel antialiased text if we k...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-03-05 21:54 PST by Simon Fraser (smfr)
Modified: 2017-03-06 13:46 PST (History)
6 users (show)

See Also:

Attachments
Patch (84.83 KB, patch)
2017-03-05 22:10 PST, Simon Fraser (smfr) 		zalan: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (881.30 KB, application/zip)
2017-03-05 23:32 PST, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-03-05 21:54:20 PST 
Only use layer backing store which supports subpixel antialiased text if we know subpixel antialiased will be painted into it
Comment 1 Simon Fraser (smfr) 2017-03-05 22:10:13 PST 
Created attachment 303497 [details]
Patch
Comment 2 Build Bot 2017-03-05 23:32:21 PST 
Comment on attachment 303497 [details]
Patch

Attachment 303497 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3250669

New failing tests:
compositing/contents-format/subpixel-antialiased-text-configs.html
compositing/contents-format/subpixel-antialiased-text-visibility.html
compositing/contents-format/subpixel-antialiased-text-enabled.html
compositing/contents-format/subpixel-antialiased-text-images.html
compositing/contents-format/subpixel-antialiased-text-configs-antialiasing-style.html
Comment 3 Build Bot 2017-03-05 23:32:24 PST 
Created attachment 303500 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 4 Radar WebKit Bug Importer 2017-03-06 00:08:28 PST 
<rdar://problem/30864317>
Comment 5 zalan 2017-03-06 11:11:19 PST 
Comment on attachment 303497 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303497&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:2089
> +// Returning true stops the traversal.

Out of date comment.
Comment 6 Sam Weinig 2017-03-06 11:15:42 PST 
Comment on attachment 303497 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303497&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:848
> +            logString.appendLiteral("texty");

"texty"? 🙄
Comment 7 Simon Fraser (smfr) 2017-03-06 13:46:31 PST 
https://trac.webkit.org/r213466