Bug 169181 - Web Inspector: Add settings for controlling Styles sidebar intelligence
Summary: Web Inspector: Add settings for controlling Styles sidebar intelligence
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-05 02:43 PST by Devin Rousso
Modified: 2017-03-09 02:51 PST (History)
3 users (show)

See Also:


Attachments
Patch (14.78 KB, patch)
2017-03-05 02:50 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
[Image] After Patch is applied (92.35 KB, image/png)
2017-03-05 02:51 PST, Devin Rousso
no flags Details
Patch (17.48 KB, patch)
2017-03-05 03:14 PST, Devin Rousso
timothy: review+
Details | Formatted Diff | Diff
[Image] After Patch is applied (92.21 KB, image/png)
2017-03-05 03:14 PST, Devin Rousso
no flags Details
Patch (18.40 KB, patch)
2017-03-08 15:47 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2017-03-05 02:43:25 PST
As discussed offline with Joe, it can be aggravating sometimes to click after the end of a CSS property in the styles sidebar and having a newline be automatically inserted.  The same is true of the warning icons, especially for those who are well versed with CSS and understand what the strikethroughs can mean.
Comment 1 Devin Rousso 2017-03-05 02:50:51 PST
Created attachment 303449 [details]
Patch
Comment 2 Devin Rousso 2017-03-05 02:51:12 PST
Created attachment 303450 [details]
[Image] After Patch is applied
Comment 3 Devin Rousso 2017-03-05 03:14:24 PST
Created attachment 303451 [details]
Patch
Comment 4 Devin Rousso 2017-03-05 03:14:54 PST
Created attachment 303452 [details]
[Image] After Patch is applied

Had to rework a small spacing issue :D
Comment 5 Joseph Pecoraro 2017-03-06 11:31:14 PST
Interesting! We may need to move to multiple columns in the Settings pane, its starting to get longer. I haven't yet reviewed the patch, I want to try it. We don't want to go overboard with settings so I'd like to see what others think (and myself after I try it).
Comment 6 Timothy Hatcher 2017-03-08 09:45:19 PST
Comment on attachment 303451 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303451&action=review

> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:129
> +localizedStrings["CSS Editing:"] = "CSS Editing:";

The sidebar is "Styles" or "Rules", we don't use CSS in the UI.

> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:717
> +localizedStrings["Show warning icons"] = "Show warning icons";

"Show inline warnings". The fact that is an icon is an implementation detail.
Comment 7 Devin Rousso 2017-03-08 15:47:19 PST
Created attachment 303854 [details]
Patch

So I reworked the "Select text on first click" option to work more like how Chrome/Firefox currently function, meaning that it will always select the text range only on the first click.
Comment 8 WebKit Commit Bot 2017-03-09 02:51:40 PST
Comment on attachment 303854 [details]
Patch

Clearing flags on attachment: 303854

Committed r213635: <http://trac.webkit.org/changeset/213635>
Comment 9 WebKit Commit Bot 2017-03-09 02:51:45 PST
All reviewed patches have been landed.  Closing bug.