Bug 169181 – Web Inspector: Add settings for controlling Styles sidebar intelligence

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

As discussed offline with Joe, it can be aggravating sometimes to click after the end of a CSS property in the styles sidebar and having a newline be automatically inserted.  The same is true of the warning icons, especially for those who are well versed with CSS and understand what the strikethroughs can mean.

[Devin Rousso]

Created attachment 303449 [details]
Patch

[Devin Rousso]

Created attachment 303450 [details]
[Image] After Patch is applied

[Devin Rousso]

Created attachment 303451 [details]
Patch

[Devin Rousso]

Created attachment 303452 [details]
[Image] After Patch is applied

Had to rework a small spacing issue :D

[Joseph Pecoraro]

Interesting! We may need to move to multiple columns in the Settings pane, its starting to get longer. I haven't yet reviewed the patch, I want to try it. We don't want to go overboard with settings so I'd like to see what others think (and myself after I try it).

[Timothy Hatcher]

Comment on attachment 303451 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303451&action=review

> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:129
> +localizedStrings["CSS Editing:"] = "CSS Editing:";

The sidebar is "Styles" or "Rules", we don't use CSS in the UI.

> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:717
> +localizedStrings["Show warning icons"] = "Show warning icons";

"Show inline warnings". The fact that is an icon is an implementation detail.

[Devin Rousso]

Created attachment 303854 [details]
Patch

So I reworked the "Select text on first click" option to work more like how Chrome/Firefox currently function, meaning that it will always select the text range only on the first click.

[WebKit Commit Bot]

Comment on attachment 303854 [details]
Patch

Clearing flags on attachment: 303854

Committed r213635: <http://trac.webkit.org/changeset/213635>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.