Bug 169176 – Align initEvent / initCustomEvent / initMessageEvent with the latest specification

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Align initEvent / initCustomEvent / initMessageEvent with the latest specification:
- https://github.com/whatwg/html/pull/2410
- https://github.com/w3c/web-platform-tests/pull/5044
- https://github.com/whatwg/dom/pull/417
- https://github.com/w3c/web-platform-tests/pull/5043

[Chris Dumez]

Created attachment 303416 [details]
WIP patch

[Build Bot]

Comment on attachment 303416 [details]
WIP patch

Attachment 303416 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3243428

New failing tests:
imported/w3c/web-platform-tests/dom/interfaces.html
fast/eventsource/eventsource-attribute-listeners.html
fast/events/init-events.html
imported/w3c/web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.html
imported/w3c/web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https.html

[Build Bot]

Created attachment 303419 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 303416 [details]
WIP patch

Attachment 303416 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3243436

New failing tests:
imported/w3c/web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https.html
fast/eventsource/eventsource-attribute-listeners.html
fast/events/init-events.html
imported/w3c/web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.html
imported/w3c/web-platform-tests/dom/interfaces.html

[Build Bot]

Created attachment 303421 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 303416 [details]
WIP patch

Attachment 303416 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3243434

New failing tests:
imported/w3c/web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https.html
fast/events/init-events.html
imported/w3c/web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.html
fast/eventsource/eventsource-attribute-listeners.html

[Build Bot]

Created attachment 303423 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 303416 [details]
WIP patch

Attachment 303416 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3243440

New failing tests:
imported/w3c/web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https.html
fast/eventsource/eventsource-attribute-listeners.html
fast/events/init-events.html
imported/w3c/web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.html
imported/w3c/web-platform-tests/dom/interfaces.html

[Build Bot]

Created attachment 303424 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Chris Dumez]

Created attachment 303433 [details]
WIP Patch

[Chris Dumez]

Created attachment 303520 [details]
Patch

[Alex Christensen]

Comment on attachment 303520 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303520&action=review

> LayoutTests/fast/eventsource/eventsource-attribute-listeners.html:39
> -evt.initMessageEvent("message", false, false, "hello", null, null, null, null);
> +evt.initMessageEvent("message", false, false, "hello", null, null, null, []);

What happens if you call this with null?

[Chris Dumez]

(In reply to comment #12)
> Comment on attachment 303520 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=303520&action=review
> 
> > LayoutTests/fast/eventsource/eventsource-attribute-listeners.html:39
> > -evt.initMessageEvent("message", false, false, "hello", null, null, null, null);
> > +evt.initMessageEvent("message", false, false, "hello", null, null, null, []);
> 
> What happens if you call this with null?

It throws a TypeError as per WebIDL. This is consistent with Firefox as well. There is a slight backward compatibility risk here, as mentioned in the Changelog but we can always mark the parameter as nullable later if we see it breaks anything.

[WebKit Commit Bot]

Comment on attachment 303520 [details]
Patch

Clearing flags on attachment: 303520

Committed r213517: <http://trac.webkit.org/changeset/213517>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.