Bug 169171 - Perf and layout test results should report using correct scm revision
Summary: Perf and layout test results should report using correct scm revision
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Minor
Assignee: Nobody
Depends on:
Reported: 2017-03-04 10:24 PST by Kocsen Chung
Modified: 2017-03-07 19:46 PST (History)
9 users (show)

See Also:

Patch (13.37 KB, patch)
2017-03-04 10:26 PST, Kocsen Chung
no flags Details | Formatted Diff | Diff
Patch (14.96 KB, patch)
2017-03-07 09:52 PST, Kocsen Chung
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kocsen Chung 2017-03-04 10:24:41 PST
Perf test and layout test results should report using the correct scm native       revision as an identifier; for more accurate record keeping.
Comment 1 Kocsen Chung 2017-03-04 10:26:15 PST
Created attachment 303399 [details]
Comment 2 Ryosuke Niwa 2017-03-06 15:37:41 PST
Comment on attachment 303399 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=303399&action=review

> Tools/Scripts/webkitpy/common/checkout/scm/git.py:279
> +        # If `revision` is composed of 0-6 digits, assume SVN revision. Else, assume git hash
> +        svn_revision_regex = re.compile('^[1-9]\d{0,5}$')

This is a rather dangerous assumption. A git hash especially not the full length one could entirely consist of digits.

> Tools/Scripts/webkitpy/common/checkout/scm/git.py:-289
>      def timestamp_of_revision(self, path, revision):
> -        git_log = self._most_recent_log_matching('git-svn-id:.*@%s' % revision, path)

I think it's better to add a new version of this function which gets the timestamp for the "native" revision.

> Tools/Scripts/webkitpy/common/checkout/scm/scm.py:72
> +                                           cwd=cwd,

Nit: This is wrong indentation.
Per WebKit's style guideline, these text should be exactly 4 spaces on the right of the beginning of "return self._executive..."
Comment 3 Kocsen Chung 2017-03-07 09:52:19 PST
Created attachment 303669 [details]
Comment 4 Kocsen Chung 2017-03-07 09:53:34 PST
Take 2: incorporating Ryosuke's comments.
Comment 5 WebKit Commit Bot 2017-03-07 19:46:23 PST
Comment on attachment 303669 [details]

Clearing flags on attachment: 303669

Committed r213562: <http://trac.webkit.org/changeset/213562>
Comment 6 WebKit Commit Bot 2017-03-07 19:46:30 PST
All reviewed patches have been landed.  Closing bug.