Bug 169170 – [Cocoa] libwebrtc.dylib’s current version is fixed at 1.0.0

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

libwebrtc.dylib’s current version is fixed at 1.0.0, so it’s impossible to tell which version of the library was present at link time, and harder to diagnose version incompatibilities at runtime.

Patch forthcoming.

Created attachment 303398 [details]
Set DYLIB_CURRENT_VERSION

[Alex Christensen]

Comment on attachment 303398 [details]
Set DYLIB_CURRENT_VERSION

View in context: https://bugs.webkit.org/attachment.cgi?id=303398&action=review

> Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig:1
> +// Copyright (C) 2009 Apple Inc. All rights reserved.

2017?

> Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig:36
> +SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8;

Why 8?  This definitely matches what is done elsewhere.

Comment on attachment 303398 [details]
Set DYLIB_CURRENT_VERSION

View in context: https://bugs.webkit.org/attachment.cgi?id=303398&action=review

>> Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig:1
>> +// Copyright (C) 2009 Apple Inc. All rights reserved.
> 
> 2017?

Making a copy of this file in 2017 doesn’t introduce any new content.

>> Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig:36
>> +SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8;
> 
> Why 8?  This definitely matches what is done elsewhere.

My recollection is during the time the iOS fork of WebKit existed, it would occasionally update this to match the most recent upstream Mac OS X version, and that most recently happened with 10.8. Because of the way iOS software updates are installed, it’s not important to use different prefixes for different target OS versions. Because the libwebrtc project doesn’t build any bundles, it doesn’t use the bundle version prefix, but we use the same Version.xcconfig across all projects.

[WebKit Commit Bot]

Comment on attachment 303398 [details]
Set DYLIB_CURRENT_VERSION

Clearing flags on attachment: 303398

Committed r213432: <http://trac.webkit.org/changeset/213432>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.