Symbols from Shared/API/Cocoa/WebKit.m goes to the binary, but they are not in any header file. This causes mismatch of symbols between headers and binary, which makes TAPI unhappy. In order to ensure that symbols from headers and binary matches precisely, we should move the declaration of symbols from Shared/API/Cocoa/WebKit.m to a separate header file.
Created attachment 303370 [details] Proposed patch
Comment on attachment 303370 [details] Proposed patch Attachment 303370 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3234483 New failing tests: http/tests/media/media-document.html
Created attachment 303378 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 303370 [details] Proposed patch This looks fine to me. But there is unpleasant asymmetry with the private header, which is not compiled. Since most of the macro is duplicated anyway, I'm now thinking that this public header could also be TAPI only, and then WebKit.m won't change.
Created attachment 303401 [details] Updated patch > Since most of the macro is duplicated anyway, I'm now thinking that this > public header could also be TAPI only, and then WebKit.m won't change. That's a good idea. Keeps things simple and consistent. Patch updated.
The commit-queue encountered the following flaky tests while processing attachment 303401 [details]: media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html bug 169159 (authors: graouts@apple.com and ryanhaddad@apple.com) The commit-queue is continuing to process your patch.
The commit-queue encountered the following flaky tests while processing attachment 303401 [details]: media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html bug 169158 (authors: graouts@apple.com and ryanhaddad@apple.com) The commit-queue is continuing to process your patch.
Comment on attachment 303401 [details] Updated patch Clearing flags on attachment: 303401 Committed r213428: <http://trac.webkit.org/changeset/213428>
All reviewed patches have been landed. Closing bug.