This will be needed soon when we use breakpoint instructions to implement non-polling VM traps, and need to discern between a VM trap signal and a genuine assertion breakpoint.
Created attachment 303334 [details] proposed patch.
Comment on attachment 303334 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=303334&action=review r=me > Source/JavaScriptCore/assembler/ARM64Assembler.h:874 > + int mask = excepnGenerationImmMask(); The name "mask" is a little misleading. It is really a mask of the immediate. > Source/JavaScriptCore/assembler/ARMAssembler.h:708 > + ARMWord mask = (0xff0 << 4) | 0xf); Ditto on the name "mask". > Source/JavaScriptCore/assembler/ARMv7Assembler.h:993 > + unsigned short mask = 0xff; Ditto
Thanks for the review. I renames the mask variables to immediateMask. Landed in r213367: <http://trac.webkit.org/r213367>.
Landed a ARM64 build fix for this patch in r213381: <http://trac.webkit.org/r213381>.