Bug 169139 - Add MacroAssembler::isBreakpoint() query function.
Summary: Add MacroAssembler::isBreakpoint() query function.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 168920
  Show dependency treegraph
 
Reported: 2017-03-03 11:57 PST by Mark Lam
Modified: 2017-03-03 13:36 PST (History)
6 users (show)

See Also:


Attachments
proposed patch. (10.77 KB, patch)
2017-03-03 12:20 PST, Mark Lam
msaboff: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2017-03-03 11:57:14 PST
This will be needed soon when we use breakpoint instructions to implement non-polling VM traps, and need to discern between a VM trap signal and a genuine assertion breakpoint.
Comment 1 Mark Lam 2017-03-03 12:20:11 PST
Created attachment 303334 [details]
proposed patch.
Comment 2 Michael Saboff 2017-03-03 12:56:54 PST
Comment on attachment 303334 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=303334&action=review

r=me

> Source/JavaScriptCore/assembler/ARM64Assembler.h:874
> +        int mask = excepnGenerationImmMask();

The name "mask" is a little misleading.  It is really a mask of the immediate.

> Source/JavaScriptCore/assembler/ARMAssembler.h:708
> +            ARMWord mask = (0xff0 << 4) | 0xf);

Ditto on the name "mask".

> Source/JavaScriptCore/assembler/ARMv7Assembler.h:993
> +        unsigned short mask = 0xff;

Ditto
Comment 3 Mark Lam 2017-03-03 13:30:46 PST
Thanks for the review.  I renames the mask variables to immediateMask.

Landed in r213367: <http://trac.webkit.org/r213367>.
Comment 4 Mark Lam 2017-03-03 13:36:48 PST
Landed a ARM64 build fix for this patch in r213381: <http://trac.webkit.org/r213381>.