Bug 169137 - [iOS] Throttle SVG SMIL animations to 30fps in low power mode
Summary: [iOS] Throttle SVG SMIL animations to 30fps in low power mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-03-03 09:40 PST by Chris Dumez
Modified: 2017-03-03 15:53 PST (History)
7 users (show)

See Also:


Attachments
Patch (14.30 KB, patch)
2017-03-03 11:48 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-03-03 09:40:45 PST
Throttle SVG SMIL animations to 30fps in low power mode on iOS to save battery.
Comment 1 Radar WebKit Bug Importer 2017-03-03 09:41:22 PST
<rdar://problem/30833754>
Comment 2 Chris Dumez 2017-03-03 11:48:47 PST
Created attachment 303331 [details]
Patch
Comment 3 Simon Fraser (smfr) 2017-03-03 12:07:26 PST
Comment on attachment 303331 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303331&action=review

> Source/WebCore/svg/animation/SMILTimeContainer.cpp:39
> +static const Seconds SMILAnimationFrameDelay { 1.0 / 60 };
> +static const Seconds SMILAnimationFrameThrottledDelay { 1.0 / 30 };

Not sure why these aren't slightly less than these values, as we do for CSS and timer-based rAF.
Comment 4 Chris Dumez 2017-03-03 12:10:03 PST
Comment on attachment 303331 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303331&action=review

>> Source/WebCore/svg/animation/SMILTimeContainer.cpp:39
>> +static const Seconds SMILAnimationFrameThrottledDelay { 1.0 / 30 };
> 
> Not sure why these aren't slightly less than these values, as we do for CSS and timer-based rAF.

Would you like me to align the values in this patch?
Comment 5 WebKit Commit Bot 2017-03-03 15:53:43 PST
Comment on attachment 303331 [details]
Patch

Clearing flags on attachment: 303331

Committed r213393: <http://trac.webkit.org/changeset/213393>
Comment 6 WebKit Commit Bot 2017-03-03 15:53:48 PST
All reviewed patches have been landed.  Closing bug.