Bug 169136 - We should only check for traps that we're able to handle.
Summary: We should only check for traps that we're able to handle.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-03 09:19 PST by Mark Lam
Modified: 2017-03-03 09:48 PST (History)
4 users (show)

See Also:


Attachments
proposed patch. (5.30 KB, patch)
2017-03-03 09:25 PST, Mark Lam
msaboff: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2017-03-03 09:19:07 PST
The execute methods in interpreter were checking for the existence of any traps (without masking) and only handling a subset of those via a mask.  This can result in a failed assertion on debug builds.
Comment 1 Mark Lam 2017-03-03 09:25:42 PST
Created attachment 303326 [details]
proposed patch.
Comment 2 Michael Saboff 2017-03-03 09:32:03 PST
Comment on attachment 303326 [details]
proposed patch.

r=me
Comment 3 Mark Lam 2017-03-03 09:48:13 PST
Thanks for the review.  Landed in r213367: <http://trac.webkit.org/r213367>.