Bug 169126 - [GTK] Two file reset tests are failing in the bots since they were added in r213042
Summary: [GTK] Two file reset tests are failing in the bots since they were added in r...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2017-03-03 02:57 PST by Carlos Garcia Campos
Modified: 2017-03-05 03:10 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.75 KB, patch)
2017-03-03 02:59 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-03-03 02:57:23 PST
They are failing because the GTK+ event sender is not firing the second UIHelper.activateAt() after the change event. In onse case this causes that the reset button is not locked, and in the other one the file input is not unfocused.

https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r213357%20(21247)/fast/forms/file/file-input-reset-using-open-panel-diffs.html
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r213357%20(21247)/fast/forms/file/file-reset-in-change-using-open-panel-diffs.html

This is because the change event is emitted before the mouse up, and the GTK+ event sender ignores mouse down events when the button is already down to not confuse Xvfb. So, we can easily fix theses tests by using a timeout to ensure the next UIHelper.activateAt() happens in a different run loop iteration, after the mouse up.
Comment 1 Carlos Garcia Campos 2017-03-03 02:59:51 PST
Created attachment 303309 [details]
Patch
Comment 2 WebKit Commit Bot 2017-03-05 03:10:13 PST
Comment on attachment 303309 [details]
Patch

Clearing flags on attachment: 303309

Committed r213434: <http://trac.webkit.org/changeset/213434>
Comment 3 WebKit Commit Bot 2017-03-05 03:10:19 PST
All reviewed patches have been landed.  Closing bug.