Bug 169108 - [iOS] Enable webrtc tests for debug builds
Summary: [iOS] Enable webrtc tests for debug builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-03-02 16:26 PST by youenn fablet
Modified: 2017-09-28 11:35 PDT (History)
5 users (show)

See Also:

Attachments
Patch for landing (2.00 KB, patch)
2017-03-02 16:28 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-03-02 16:26:15 PST 
[iOS] Enable webrtc tests for debug builds
Comment 1 youenn fablet 2017-03-02 16:28:58 PST 
Created attachment 303268 [details]
Patch for landing
Comment 2 WebKit Commit Bot 2017-03-02 16:31:21 PST 
Attachment 303268 [details] did not pass style-queue:


ERROR: LayoutTests/ChangeLog:8:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2017-03-02 17:33:49 PST 
Comment on attachment 303268 [details]
Patch for landing

Clearing flags on attachment: 303268

Committed r213332: <http://trac.webkit.org/changeset/213332>
Comment 4 WebKit Commit Bot 2017-03-02 17:33:52 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Ryan Haddad 2017-03-02 19:52:02 PST 
It appears that the tests are failing or timing out on ios-simulator debug:

https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Debug%20WK2%20(Tests)/builds/3939
Comment 6 Ryan Haddad 2017-03-02 19:57:59 PST 
Reverted r213332 for reason:

These tests are failing on ios-simulator debug.

Committed r213343: <http://trac.webkit.org/changeset/213343>
Comment 7 Radar WebKit Bug Importer 2017-08-29 09:49:58 PDT 
<rdar://problem/34134403>
Comment 8 Jon Lee 2017-08-29 15:43:17 PDT 
Is there anything left to do here?
Comment 9 youenn fablet 2017-09-28 11:35:11 PDT 
Closing bug as tests have beeb improved and expectations updated in other patches