RESOLVED FIXED 169106
Modernize ContentExtensionParser 
https://bugs.webkit.org/show_bug.cgi?id=169106
Summary Modernize ContentExtensionParser
Alex Christensen
Reported 2017-03-02 15:51:33 PST
Modernize ContentExtensionParser
Attachments
Patch (19.92 KB, patch)
2017-03-02 15:54 PST, Alex Christensen 		aestes: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-03-02 15:54:49 PST
Created attachment 303262 [details] Patch
Andy Estes
Comment 2 2017-03-02 16:00:44 PST
Comment on attachment 303262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303262&action=review > Source/WebCore/contentextensions/ContentExtensionParser.cpp:67 > - ASSERT(vector.isEmpty()); > + Vector<String> domains; I'd declare this farther down, before the for loop. > Source/WebCore/contentextensions/ContentExtensionParser.cpp:86 > + return domains; The NRVO won't apply here, so you should WTFMove() domains. > Source/WebCore/contentextensions/ContentExtensionParser.cpp:188 > + return trigger; Ditto. > Source/WebCore/contentextensions/ContentExtensionParser.cpp:299 > + return ruleList; Ditto. > Source/WebCore/contentextensions/ContentExtensionParser.cpp:328 > + return ruleList; Ditto.
Alex Christensen
Comment 3 2017-03-02 16:17:52 PST
http://trac.webkit.org/r213322
Note You need to log in before you can comment on or make changes to this bug.