Bug 169102 - Update WKWebsiteDatastoreConfiguration SPI
Summary: Update WKWebsiteDatastoreConfiguration SPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-02 15:31 PST by Brady Eidson
Modified: 2017-03-02 17:33 PST (History)
2 users (show)

See Also:

Attachments
Patch (10.13 KB, patch)
2017-03-02 15:33 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (10.14 KB, patch)
2017-03-02 15:41 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2017-03-02 15:31:34 PST 
Update WKWebsiteDatastoreConfiguration SPI

Based on late review feedback to the initial patch.
Comment 1 Brady Eidson 2017-03-02 15:33:44 PST 
Created attachment 303255 [details]
Patch
Comment 2 Tim Horton 2017-03-02 15:36:31 PST 
Comment on attachment 303255 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303255&action=review

> Source/WebKit2/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm:51
> +    _webStorageDirectoryURL = [url copy];

You need a whole bunch of adopts!
Comment 3 Brady Eidson 2017-03-02 15:41:27 PST 
Created attachment 303259 [details]
Patch
Comment 4 Brady Eidson 2017-03-02 15:41:51 PST 
Waiting for EWS then will CQ+
Comment 5 WebKit Commit Bot 2017-03-02 17:33:28 PST 
Comment on attachment 303259 [details]
Patch

Clearing flags on attachment: 303259

Committed r213331: <http://trac.webkit.org/changeset/213331>
Comment 6 WebKit Commit Bot 2017-03-02 17:33:31 PST 
All reviewed patches have been landed.  Closing bug.