Bug 169100 - flex-basis should be 0% (not 0px) when omitted from flex shorthand
Summary: flex-basis should be 0% (not 0px) when omitted from flex shorthand
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-03-02 14:25 PST by Dave Hyatt
Modified: 2017-03-02 15:56 PST (History)
1 user (show)

See Also:

Attachments
Patch (10.54 KB, patch)
2017-03-02 14:29 PST, Dave Hyatt 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2017-03-02 14:25:33 PST 
flex-basis should be 0% (not 0px) when omitted from flex shorthand
Comment 1 Dave Hyatt 2017-03-02 14:26:32 PST 
rdar://problem/30796872
Comment 2 Dave Hyatt 2017-03-02 14:29:32 PST 
Created attachment 303242 [details]
Patch
Comment 3 Dave Hyatt 2017-03-02 14:37:11 PST 
Fixed in r213305.
Comment 4 Ryan Haddad 2017-03-02 15:36:11 PST 
This change caused fast/css/flex-calculated-value.html to fail. I assume this test should have been updated too?

https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK1%20(Tests)/r213308%20(14227)/results.html
Comment 5 Ryan Haddad 2017-03-02 15:56:46 PST 
I updated the test in http://trac.webkit.org/projects/webkit/changeset/213315. EWS would have caught this had it been allowed to finish.