RESOLVED FIXED169098
Sufficently large timeValue and timeScale arguments to MediaTime will cause wrapping in toTimeScale(). 
https://bugs.webkit.org/show_bug.cgi?id=169098
Summary Sufficently large timeValue and timeScale arguments to MediaTime will cause w...
Jer Noble
Reported 2017-03-02 14:16:23 PST
Sufficently large timeValue and timeScale arguments to MediaTime will cause wrapping in toTimeScale().
Attachments
Patch (4.13 KB, patch)
2017-03-02 14:17 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (4.13 KB, patch)
2017-03-02 15:28 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (4.75 KB, patch)
2017-03-02 15:30 PST, Jer Noble 		keith_miller: review+
DetailsFormatted DiffDiff
Patch for landing (5.11 KB, patch)
2017-03-02 16:15 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.11 KB, patch)
2017-03-02 16:18 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2017-03-02 14:17:43 PST
Created attachment 303239 [details] Patch
Jer Noble
Comment 2 2017-03-02 15:28:36 PST
Created attachment 303253 [details] Patch
Jer Noble
Comment 3 2017-03-02 15:30:01 PST
Created attachment 303254 [details] Patch
Keith Miller
Comment 4 2017-03-02 15:57:39 PST
Comment on attachment 303254 [details] Patch r=me. I believe in the maths.
Jer Noble
Comment 5 2017-03-02 16:15:28 PST
Created attachment 303264 [details] Patch for landing Added a couple more tests to ensure that large timeScale values didn\'t cause a overflow.
Jon Lee
Comment 6 2017-03-02 16:16:24 PST
rdar://problem/30812277
Jer Noble
Comment 7 2017-03-02 16:18:13 PST
Created attachment 303265 [details] Patch for landing And one more to take care of the Windows EWS warnings about int => uint32_t conversion.
Jer Noble
Comment 8 2017-03-02 16:27:39 PST
Committed r213324: <http://trac.webkit.org/changeset/213324>
Note You need to log in before you can comment on or make changes to this bug.