Bug 169088 - Add Options::alwaysCheckTraps() and Options::usePollingTraps() options.
Summary: Add Options::alwaysCheckTraps() and Options::usePollingTraps() options.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 168920
  Show dependency tree / graph
 
Reported: 2017-03-02 12:15 PST by Mark Lam
Modified: 2017-03-02 14:05 PST (History)
6 users (show)

See Also:

Attachments
proposed patch. (6.69 KB, patch)
2017-03-02 12:51 PST, Mark Lam 		mark.lam: review-
Details | Formatted Diff | Diff
proposed patch. (8.13 KB, patch)
2017-03-02 13:32 PST, Mark Lam 		no flags Details | Formatted Diff | Diff
proposed patch. (8.15 KB, patch)
2017-03-02 13:49 PST, Mark Lam 		keith_miller: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2017-03-02 12:15:39 PST 
This enables the use of polling VM traps all the time.  This will be useful for benchmark comparisons, as well as for forcing polling traps later for ports that don't support signal based traps.
Comment 1 Mark Lam 2017-03-02 12:51:52 PST 
Created attachment 303226 [details]
proposed patch.
Comment 2 Mark Lam 2017-03-02 13:32:05 PST 
Created attachment 303229 [details]
proposed patch.
Comment 3 Mark Lam 2017-03-02 13:49:43 PST 
Created attachment 303233 [details]
proposed patch.
Comment 4 Keith Miller 2017-03-02 13:50:14 PST 
Comment on attachment 303233 [details]
proposed patch.

r=me.
Comment 5 Mark Lam 2017-03-02 14:05:37 PST 
Thanks for the review.  Landed in r213302: <http://trac.webkit.org/r213302>.