WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
169084
Add a script for automatically running the buildbot configurations on a test environment.
https://bugs.webkit.org/show_bug.cgi?id=169084
Summary
Add a script for automatically running the buildbot configurations on a test ...
Carlos Alberto Lopez Perez
Reported
2017-03-02 10:33:50 PST
I have been working on a script that does the following: * Creates a temporal workingdir * Installs buildbot and its dependencies there (very same version used by the webkit.org buildbot master
https://build.webkit.org/about
). This is important as there are problems that that may not be detected if you don't test with the same version that will be used on production. * Copies the buildmaster config files to the temporal workingdir. * Performs the required steps to start a buildmaster. * Creates the required config for each slave and starts all of them. Then you can use your browser to log into the test buildmaster at
http://localhost:8710/
and test to trigger manual builds, etc. So you can actually test any configuration changes on the buildmaster on a test environment that is pretty much identical to the production one. When you finish testing, simply press CTRL+C and all the temporal files will be cleaned. Note that if you actually want to trigger builds, the default path for the temporal workingdir on Linux (/tmp/) may have not enough free space. You can specify another temporal directory with the --base-temp-dir argument.
Attachments
Patch
(17.29 KB, patch)
2017-03-02 10:47 PST
,
Carlos Alberto Lopez Perez
no flags
Details
Formatted Diff
Diff
Patch
(17.31 KB, patch)
2017-03-02 14:45 PST
,
Carlos Alberto Lopez Perez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1
2017-03-02 10:47:20 PST
Created
attachment 303216
[details]
Patch
WebKit Commit Bot
Comment 2
2017-03-02 10:49:28 PST
Attachment 303216
[details]
did not pass style-queue: ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py:213: [start_worker] Instance of 'Popen' has no 'kill' member [pylint/E1101] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 3
2017-03-02 13:11:38 PST
Interesting! Aakash and Dean, did you have some automation for setting up test buildbot instances? What do you think?
Carlos Alberto Lopez Perez
Comment 4
2017-03-02 14:45:02 PST
Created
attachment 303246
[details]
Patch Fix some typos and improve the wording on the help strings for the arguments
WebKit Commit Bot
Comment 5
2017-03-02 14:56:24 PST
Attachment 303246
[details]
did not pass style-queue: ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py:213: [start_worker] Instance of 'Popen' has no 'kill' member [pylint/E1101] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Alberto Lopez Perez
Comment 6
2017-03-07 05:11:43 PST
ping reviewers?
Michael Catanzaro
Comment 7
2017-09-22 07:27:10 PDT
Comment on
attachment 303246
[details]
Patch I have not actually reviewed this script. Maybe that's bad of me. :) But you can commit it.
Aakash Jain
Comment 8
2017-09-22 09:22:10 PDT
Thanks for adding the script. I have verified that the script works fine. Let me review it today. I might have few comments.
Michael Catanzaro
Comment 9
2017-09-22 09:45:22 PDT
Comment on
attachment 303246
[details]
Patch Sure, I was just approving it because I figured nobody would want to review it.
Michael Catanzaro
Comment 10
2017-10-15 08:10:30 PDT
(In reply to Aakash Jain from
comment #8
)
> Thanks for adding the script. I have verified that the script works fine. > > Let me review it today. I might have few comments.
Aakash, are you still planning to review this?
Michael Catanzaro
Comment 11
2017-10-26 20:11:30 PDT
Comment on
attachment 303246
[details]
Patch (Carlos Lopez, you can commit this, barring future negative feedback.)
Aakash Jain
Comment 12
2017-10-26 20:23:29 PDT
Yeah, please go ahead. The script works. We can make the improvements on ongoing basis.
Aakash Jain
Comment 13
2017-11-30 10:49:34 PST
Carlos, can you please commit it?
WebKit Commit Bot
Comment 14
2017-11-30 11:29:58 PST
Comment on
attachment 303246
[details]
Patch Clearing flags on attachment: 303246 Committed
r225336
: <
https://trac.webkit.org/changeset/225336
>
WebKit Commit Bot
Comment 15
2017-11-30 11:30:00 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 16
2017-11-30 11:30:45 PST
<
rdar://problem/35777704
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug