Bug 169079 - Allow render tree building before loading stylesheet elements
Summary: Allow render tree building before loading stylesheet elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 169211
Blocks: 172092 149157
  Show dependency treegraph
 
Reported: 2017-03-02 05:47 PST by Antti Koivisto
Modified: 2017-05-14 04:09 PDT (History)
8 users (show)

See Also:


Attachments
wip (11.42 KB, patch)
2017-03-02 05:48 PST, Antti Koivisto
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-elcapitan (241.29 KB, application/zip)
2017-03-02 06:43 PST, Build Bot
no flags Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (270.90 KB, application/zip)
2017-03-02 06:44 PST, Build Bot
no flags Details
Archive of layout-test-results from ews116 for mac-elcapitan (226.71 KB, application/zip)
2017-03-02 06:45 PST, Build Bot
no flags Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (247.32 KB, application/zip)
2017-03-02 06:54 PST, Build Bot
no flags Details
wip (12.20 KB, patch)
2017-03-02 07:33 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
wip (12.08 KB, patch)
2017-03-02 07:58 PST, Antti Koivisto
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-elcapitan (944.58 KB, application/zip)
2017-03-02 09:33 PST, Build Bot
no flags Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (994.71 KB, application/zip)
2017-03-02 09:39 PST, Build Bot
no flags Details
Archive of layout-test-results from ews112 for mac-elcapitan (1.74 MB, application/zip)
2017-03-02 09:45 PST, Build Bot
no flags Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (909.18 KB, application/zip)
2017-03-02 09:48 PST, Build Bot
no flags Details
wip (14.26 KB, patch)
2017-03-03 11:51 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (20.26 KB, patch)
2017-03-06 00:56 PST, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff
patch (20.78 KB, patch)
2017-03-06 02:16 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-elcapitan (898.92 KB, application/zip)
2017-03-06 03:30 PST, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2017-03-02 05:47:30 PST
Don't block style resolve and render tree building completely when stylesheet are loading.
Comment 1 Antti Koivisto 2017-03-02 05:48:48 PST
Created attachment 303193 [details]
wip
Comment 2 Build Bot 2017-03-02 06:43:19 PST
Comment on attachment 303193 [details]
wip

Attachment 303193 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3222136

Number of test failures exceeded the failure limit.
Comment 3 Build Bot 2017-03-02 06:43:24 PST
Created attachment 303195 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Build Bot 2017-03-02 06:44:12 PST
Comment on attachment 303193 [details]
wip

Attachment 303193 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3222135

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2017-03-02 06:44:17 PST
Created attachment 303196 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-03-02 06:45:17 PST
Comment on attachment 303193 [details]
wip

Attachment 303193 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3222129

Number of test failures exceeded the failure limit.
Comment 7 Build Bot 2017-03-02 06:45:22 PST
Created attachment 303197 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 8 Build Bot 2017-03-02 06:54:21 PST
Comment on attachment 303193 [details]
wip

Attachment 303193 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3222139

Number of test failures exceeded the failure limit.
Comment 9 Build Bot 2017-03-02 06:54:26 PST
Created attachment 303198 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 10 Antti Koivisto 2017-03-02 07:33:29 PST
Created attachment 303201 [details]
wip
Comment 11 Antti Koivisto 2017-03-02 07:58:11 PST
Created attachment 303202 [details]
wip
Comment 12 Build Bot 2017-03-02 09:33:02 PST
Comment on attachment 303202 [details]
wip

Attachment 303202 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3222750

New failing tests:
svg/as-image/img-zoom-svg-stylesheet.html
fast/parser/adoption-agency-unload-iframe-4.html
Comment 13 Build Bot 2017-03-02 09:33:07 PST
Created attachment 303205 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 14 Build Bot 2017-03-02 09:39:47 PST
Comment on attachment 303202 [details]
wip

Attachment 303202 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3222767

New failing tests:
svg/as-image/img-zoom-svg-stylesheet.html
fast/parser/adoption-agency-unload-iframe-4.html
Comment 15 Build Bot 2017-03-02 09:39:51 PST
Created attachment 303206 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 16 Build Bot 2017-03-02 09:45:45 PST
Comment on attachment 303202 [details]
wip

Attachment 303202 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3222770

New failing tests:
svg/as-image/img-zoom-svg-stylesheet.html
fast/parser/adoption-agency-unload-iframe-4.html
Comment 17 Build Bot 2017-03-02 09:45:49 PST
Created attachment 303208 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 18 Build Bot 2017-03-02 09:48:52 PST
Comment on attachment 303202 [details]
wip

Attachment 303202 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3222759

New failing tests:
svg/as-image/img-zoom-svg-stylesheet.html
Comment 19 Build Bot 2017-03-02 09:48:56 PST
Created attachment 303210 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 20 Antti Koivisto 2017-03-03 11:51:37 PST
Created attachment 303333 [details]
wip
Comment 21 Antti Koivisto 2017-03-06 00:56:58 PST
Created attachment 303502 [details]
patch
Comment 22 Radar WebKit Bug Importer 2017-03-06 01:52:11 PST
<rdar://problem/30865709>
Comment 23 Andreas Kling 2017-03-06 02:07:26 PST
Comment on attachment 303502 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303502&action=review

r=me

> Source/WebCore/style/StyleScope.h:155
> -    int m_pendingStyleSheetCount { 0 };
> +    HashSet<const Node*> m_nodesWithPendingSheets;

It would be nice to have some assertion that nodes actually get disappeared from this set in an orderly fashion.
Comment 24 Antti Koivisto 2017-03-06 02:16:38 PST
Created attachment 303506 [details]
patch
Comment 25 Build Bot 2017-03-06 03:30:36 PST
Comment on attachment 303506 [details]
patch

Attachment 303506 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3251588

New failing tests:
media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html
Comment 26 Build Bot 2017-03-06 03:30:43 PST
Created attachment 303507 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 27 WebKit Commit Bot 2017-03-06 04:19:47 PST
Comment on attachment 303506 [details]
patch

Clearing flags on attachment: 303506

Committed r213446: <http://trac.webkit.org/changeset/213446>
Comment 28 WebKit Commit Bot 2017-03-06 04:19:56 PST
All reviewed patches have been landed.  Closing bug.