RESOLVED FIXED169074
Remote Inspector: Move updateTargetListing() methods to RemoteInspector.cpp 
https://bugs.webkit.org/show_bug.cgi?id=169074
Summary Remote Inspector: Move updateTargetListing() methods to RemoteInspector.cpp
Carlos Garcia Campos
Reported 2017-03-02 04:00:02 PST
They can be common.
Attachments
Patch (3.53 KB, patch)
2017-03-02 04:02 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-03-02 04:02:24 PST
Created attachment 303188 [details] Patch
Joseph Pecoraro
Comment 2 2017-03-02 20:50:02 PST
Comment on attachment 303188 [details] Patch r=me I apologize, I probably should have realized this when I added them recently. Or maybe I added these before this stuff landed in which case I didn't mess up!
Carlos Garcia Campos
Comment 3 2017-03-02 22:35:08 PST
(In reply to comment #2) > Comment on attachment 303188 [details] > Patch > > r=me > > I apologize, I probably should have realized this when I added them > recently. Or maybe I added these before this stuff landed in which case I > didn't mess up! No problem, it's understandable, because right now Cocoa is the only implementation of the remote inspector, build would have broken if there were others. I'm close to finish an initial version of the GTK+ port implementation, so hopefully this will change soon. Thanks for the review.
WebKit Commit Bot
Comment 4 2017-03-02 22:48:49 PST
Comment on attachment 303188 [details] Patch Clearing flags on attachment: 303188 Committed r213356: <http://trac.webkit.org/changeset/213356>
WebKit Commit Bot
Comment 5 2017-03-02 22:48:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.