Bug 169074 - Remote Inspector: Move updateTargetListing() methods to RemoteInspector.cpp
Summary: Remote Inspector: Move updateTargetListing() methods to RemoteInspector.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-02 04:00 PST by Carlos Garcia Campos
Modified: 2017-03-02 22:48 PST (History)
8 users (show)

See Also:


Attachments
Patch (3.53 KB, patch)
2017-03-02 04:02 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-03-02 04:00:02 PST
They can be common.
Comment 1 Carlos Garcia Campos 2017-03-02 04:02:24 PST
Created attachment 303188 [details]
Patch
Comment 2 Joseph Pecoraro 2017-03-02 20:50:02 PST
Comment on attachment 303188 [details]
Patch

r=me

I apologize, I probably should have realized this when I added them recently. Or maybe I added these before this stuff landed in which case I didn't mess up!
Comment 3 Carlos Garcia Campos 2017-03-02 22:35:08 PST
(In reply to comment #2)
> Comment on attachment 303188 [details]
> Patch
> 
> r=me
> 
> I apologize, I probably should have realized this when I added them
> recently. Or maybe I added these before this stuff landed in which case I
> didn't mess up!

No problem, it's understandable, because right now Cocoa is the only implementation of the remote inspector, build would have broken if there were others. I'm close to finish an initial version of the GTK+ port implementation, so hopefully this will change soon. Thanks for the review.
Comment 4 WebKit Commit Bot 2017-03-02 22:48:49 PST
Comment on attachment 303188 [details]
Patch

Clearing flags on attachment: 303188

Committed r213356: <http://trac.webkit.org/changeset/213356>
Comment 5 WebKit Commit Bot 2017-03-02 22:48:54 PST
All reviewed patches have been landed.  Closing bug.