Bug 169069 - Make baseline data points selectable
Summary: Make baseline data points selectable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-03-01 21:05 PST by Ryosuke Niwa
Modified: 2017-03-02 13:22 PST (History)
8 users (show)

See Also:


Attachments
Adds the feature (103.27 KB, patch)
2017-03-02 01:23 PST, Ryosuke Niwa
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-03-01 21:05:19 PST
Make baseline data points on the perf dashboard selectable
Comment 1 Ryosuke Niwa 2017-03-01 23:50:50 PST
<rdar://problem/29209427>
Comment 2 Ryosuke Niwa 2017-03-02 01:23:46 PST
Created attachment 303179 [details]
Adds the feature
Comment 3 Antti Koivisto 2017-03-02 03:00:40 PST
Comment on attachment 303179 [details]
Adds the feature

View in context: https://bugs.webkit.org/attachment.cgi?id=303179&action=review

> Websites/perf.webkit.org/ChangeLog:16
> +        to know whenever these values changed. Because of this entangled, ChartStatusView had to be aware of

"Because of this entanglement"

> Websites/perf.webkit.org/ChangeLog:19
> +        This patch dramatically simplifies the siuation by adding referencePoints() on TimeSeriesChart and

"situation"

> Websites/perf.webkit.org/ChangeLog:29
> +        memoizes the return value of a function when called with the same arguments. Delaying the computation of

"memoize"
Comment 4 Ryosuke Niwa 2017-03-02 13:22:01 PST
Committed r213300: <http://trac.webkit.org/changeset/213300>