Download attribute set to "*\" save file with name "example.com"
<rdar://problem/30740875>
Created attachment 303168 [details] Patch
Comment on attachment 303168 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303168&action=review > Source/WebCore/platform/network/ResourceResponseBase.cpp:234 > + String escapedSuggestedFilename = String(suggestedFilename).replace("\\", "\\\\").replace('\"', "\\\""); '\\' might be slightly more efficient than "\\"
(In reply to comment #3) > Comment on attachment 303168 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=303168&action=review > > > Source/WebCore/platform/network/ResourceResponseBase.cpp:234 > > + String escapedSuggestedFilename = String(suggestedFilename).replace("\\", "\\\\").replace('\"', "\\\""); > > '\\' might be slightly more efficient than "\\" This is an excellent point. I'll fix before landing.
Created attachment 303203 [details] Patch
Comment on attachment 303203 [details] Patch Clearing flags on attachment: 303203 Committed r213284: <http://trac.webkit.org/changeset/213284>
All reviewed patches have been landed. Closing bug.
Comment on attachment 303203 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303203&action=review > Source/WebCore/platform/network/ResourceResponseBase.cpp:234 > + String escapedSuggestedFilename = String(suggestedFilename).replace('\\', "\\\\").replace('\"', "\\\""); There’s an extra unneeded backslash here (was already here before the patch). It should be '"', not '\"'.
Reopening to attach new patch.
Created attachment 303485 [details] Patch
Comment on attachment 303485 [details] Patch Clearing flags on attachment: 303485 Committed r213439: <http://trac.webkit.org/changeset/213439>