RESOLVED FIXED 169059
Web Inspector: Annotators should not be enabled if the TextEditor is not visible 
https://bugs.webkit.org/show_bug.cgi?id=169059
Summary Web Inspector: Annotators should not be enabled if the TextEditor is not visible
Devin Rousso
Reported 2017-03-01 14:36:38 PST
------- Inspected URL: https://webkit.org/ Loading completed: true Frontend User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/604.1.8+ (KHTML, like Gecko) Uncaught Exceptions: - Annotators should not be enabled if the TextEditor is not visible (at SourceCodeTextEditor.js:2090:27) _basicBlockAnnotatorEnabled @ SourceCodeTextEditor.js:2090:27 _proceedPopulateWithContent @ SourceCodeTextEditor.js:471:17 _populateWithContent @ SourceCodeTextEditor.js:460:41 _contentAvailable @ SourceCodeTextEditor.js:548:34 _contentAvailable @ [native code] promiseReactionJob @ [native code] Additional Details: ------- * STEPS TO REPRODUCE 1. Navigate to a page with scripts 2. Open WebInspector
Attachments
Patch (2.46 KB, patch)
2017-03-01 14:47 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2017-03-01 14:47:43 PST
Created attachment 303126 [details] Patch
Joseph Pecoraro
Comment 2 2017-03-01 15:12:33 PST
Comment on attachment 303126 [details] Patch r=me, sounds reasonable to me.
WebKit Commit Bot
Comment 3 2017-03-01 15:58:51 PST
Comment on attachment 303126 [details] Patch Clearing flags on attachment: 303126 Committed r213251: <http://trac.webkit.org/changeset/213251>
WebKit Commit Bot
Comment 4 2017-03-01 15:58:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.