Bug 169059 - Web Inspector: Annotators should not be enabled if the TextEditor is not visible
Summary: Web Inspector: Annotators should not be enabled if the TextEditor is not visible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL: https://webkit.org/
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-01 14:36 PST by Devin Rousso
Modified: 2017-03-01 15:58 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.46 KB, patch)
2017-03-01 14:47 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2017-03-01 14:36:38 PST 
-------
Inspected URL:        https://webkit.org/
Loading completed:    true
Frontend User Agent:  Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/604.1.8+ (KHTML, like Gecko)

Uncaught Exceptions:
 - Annotators should not be enabled if the TextEditor is not visible (at SourceCodeTextEditor.js:2090:27)
    _basicBlockAnnotatorEnabled @ SourceCodeTextEditor.js:2090:27
    _proceedPopulateWithContent @ SourceCodeTextEditor.js:471:17
    _populateWithContent @ SourceCodeTextEditor.js:460:41
    _contentAvailable @ SourceCodeTextEditor.js:548:34
    _contentAvailable @ [native code]
    promiseReactionJob @ [native code]

Additional Details:
-------

* STEPS TO REPRODUCE
1. Navigate to a page with scripts
2. Open WebInspector
Comment 1 Devin Rousso 2017-03-01 14:47:43 PST 
Created attachment 303126 [details]
Patch
Comment 2 Joseph Pecoraro 2017-03-01 15:12:33 PST 
Comment on attachment 303126 [details]
Patch

r=me, sounds reasonable to me.
Comment 3 WebKit Commit Bot 2017-03-01 15:58:51 PST 
Comment on attachment 303126 [details]
Patch

Clearing flags on attachment: 303126

Committed r213251: <http://trac.webkit.org/changeset/213251>
Comment 4 WebKit Commit Bot 2017-03-01 15:58:55 PST 
All reviewed patches have been landed.  Closing bug.