Bug 169056 - Continue enabling WebRTC
Summary: Continue enabling WebRTC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-01 14:14 PST by Alex Christensen
Modified: 2017-03-02 12:18 PST (History)
6 users (show)

See Also:

Attachments
Patch (10.42 KB, patch)
2017-03-01 14:28 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (10.35 KB, patch)
2017-03-01 14:31 PST, Alex Christensen 		jonlee: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-03-01 14:14:03 PST 
Continue enabling WebRTC
Comment 1 Alex Christensen 2017-03-01 14:28:26 PST 
Created attachment 303117 [details]
Patch
Comment 2 WebKit Commit Bot 2017-03-01 14:30:11 PST 
Attachment 303117 [details] did not pass style-queue:


ERROR: Source/WebCore/PAL/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alex Christensen 2017-03-01 14:31:59 PST 
Created attachment 303118 [details]
Patch
Comment 4 Alex Christensen 2017-03-01 19:57:51 PST 
http://trac.webkit.org/r213259
Comment 5 Alex Christensen 2017-03-01 20:33:46 PST 
And out again in http://trac.webkit.org/r213260
Comment 6 Alex Christensen 2017-03-02 12:18:41 PST 
http://trac.webkit.org/r213294