WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
169049
Rename recalcStyle to resolveStyle and clean up the signature
https://bugs.webkit.org/show_bug.cgi?id=169049
Summary
Rename recalcStyle to resolveStyle and clean up the signature
Antti Koivisto
Reported
2017-03-01 11:39:55 PST
Make naming more consistent and replace an overly generic enum parameter.
Attachments
patch
(11.55 KB, patch)
2017-03-01 12:47 PST
,
Antti Koivisto
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Antti Koivisto
Comment 1
2017-03-01 12:47:14 PST
Created
attachment 303097
[details]
patch
WebKit Commit Bot
Comment 2
2017-03-01 12:49:27 PST
Attachment 303097
[details]
did not pass style-queue: ERROR: Source/WebCore/dom/Document.cpp:5042: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3
2017-03-01 20:11:53 PST
Comment on
attachment 303097
[details]
patch rs = me
Antti Koivisto
Comment 4
2017-03-01 22:18:35 PST
https://trac.webkit.org/changeset/213266
Alex Christensen
Comment 5
2017-03-01 23:01:55 PST
r213268
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug