Bug 169049 - Rename recalcStyle to resolveStyle and clean up the signature
Summary: Rename recalcStyle to resolveStyle and clean up the signature
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-01 11:39 PST by Antti Koivisto
Modified: 2017-03-01 23:01 PST (History)
7 users (show)

See Also:


Attachments
patch (11.55 KB, patch)
2017-03-01 12:47 PST, Antti Koivisto
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2017-03-01 11:39:55 PST
Make naming more consistent and replace an overly generic enum parameter.
Comment 1 Antti Koivisto 2017-03-01 12:47:14 PST
Created attachment 303097 [details]
patch
Comment 2 WebKit Commit Bot 2017-03-01 12:49:27 PST
Attachment 303097 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/Document.cpp:5042:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2017-03-01 20:11:53 PST
Comment on attachment 303097 [details]
patch

rs = me
Comment 4 Antti Koivisto 2017-03-01 22:18:35 PST
https://trac.webkit.org/changeset/213266
Comment 5 Alex Christensen 2017-03-01 23:01:55 PST
r213268