Bug 169046 – Web Inspector: Option-clicking the close tab button should close all other tabs

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

Via Nelson Thachuk:

"""
* SUMMARY
- Option-clicking the close tab button should close all other tabs

* STEPS TO REPRODUCE
1. Launch Safari
2. Navigate to a webpage
3. Show Web Inspector (⌥⌘I)
4. Option-click the close tab button of any tab

* EXPECTED RESULTS
- All other tabs should close

* ACTUAL RESULTS
- Clicked tab closes
"""

[Blaze Burg]

<rdar://problem/30621679>

[Blaze Burg]

Devin, want to knock this out?

[Devin Rousso]

Created attachment 305517 [details]
Patch

[Matt Baker]

Comment on attachment 305517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305517&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/TabBar.js:617
> +            if (event.altKey) {

Suggested early return:

if (!event.altKey) {
    this.removeTabBarItem(tabBarItem, false, true);
    return;
}

[Devin Rousso]

Created attachment 305562 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 305562 [details]
Patch

Clearing flags on attachment: 305562

Committed r214464: <http://trac.webkit.org/changeset/214464>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Joseph Pecoraro]

Is this really what we want? I can see how it is useful in Safari / Web Browser but in Web Inspector I suspect this would only be triggered accidentally / unexpectedly.