This symbols from WebProcess/cocoa/WebProcessCocoa.mm is not used by anyone outside WebKit2. Headers doesn't have this symbol. We should try to match the headers and library.
Created attachment 303077 [details] Proposed patch
Seems like this symbol is required and was added recently in https://bugs.webkit.org/show_bug.cgi?id=168739
Created attachment 303288 [details] Updated patch
Attachment 303288 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:28: Found header this file implements after a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 303288 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=303288&action=review > Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:451 > // FIXME: This should live somewhere else, and it should have the implementation in line instead of calling out to WKSI. This comment should be removed.
Comment on attachment 303288 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=303288&action=review >> Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:451 >> // FIXME: This should live somewhere else, and it should have the implementation in line instead of calling out to WKSI. > > This comment should be removed. Just kidding. This comment should stay.
Comment on attachment 303288 [details] Updated patch Clearing flags on attachment: 303288 Committed r213383: <http://trac.webkit.org/changeset/213383>
All reviewed patches have been landed. Closing bug.