Bug 169035 - [WTF] va_list is not ended in StringPrintStream
Summary: [WTF] va_list is not ended in StringPrintStream
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tomas Popela
URL:
Keywords:
Depends on:
Blocks: 104114
  Show dependency tree / graph
 
Reported: 2017-03-01 06:08 PST by Tomas Popela
Modified: 2017-03-08 06:50 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.26 KB, patch)
2017-03-01 06:12 PST, Tomas Popela 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Popela 2017-03-01 06:08:32 PST 
Detected by Coverity scan:

1. webkitgtk-2.14.5/Source/WTF/wtf/StringPrintStream.cpp:57: va_init: Initializing va_list "firstPassArgList".
4. webkitgtk-2.14.5/Source/WTF/wtf/StringPrintStream.cpp:83: missing_va_end: va_end was not called for "firstPassArgList".
#    81|       ASSERT_WITH_SECURITY_IMPLICATION(m_next < m_size);
#    82|       ASSERT(!m_buffer[m_next]);
#    83|-> }
#    84|   
#    85|   CString StringPrintStream::toCString()
Comment 1 Tomas Popela 2017-03-01 06:12:18 PST 
Created attachment 303065 [details]
Patch
Comment 2 Michael Saboff 2017-03-01 07:37:26 PST 
Comment on attachment 303065 [details]
Patch

r=me
Comment 3 Tomas Popela 2017-03-01 07:45:52 PST 
Comment on attachment 303065 [details]
Patch

Clearing flags on attachment: 303065

Committed r213223: <http://trac.webkit.org/changeset/213223>
Comment 4 Tomas Popela 2017-03-01 07:46:03 PST 
All reviewed patches have been landed.  Closing bug.