Bug 169034 - Incorrect RELEASE_ASSERT in JSGlobalObject::addStaticGlobals()
Summary: Incorrect RELEASE_ASSERT in JSGlobalObject::addStaticGlobals()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tomas Popela
URL:
Keywords: InRadar
Depends on:
Blocks: 104114
  Show dependency tree / graph
 
Reported: 2017-03-01 06:02 PST by Tomas Popela
Modified: 2017-03-10 12:09 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.64 KB, patch)
2017-03-01 06:04 PST, Tomas Popela 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Popela 2017-03-01 06:02:55 PST 
There is an incorrect RELEASE_ASSERT in JSGlobalObject::addStaticGlobals(GlobalPropertyInfo* globals, int count):

RELEASE_ASSERT(offset = startOffset + i);

it should not assign to offset, but compare to offset.
Comment 1 Tomas Popela 2017-03-01 06:04:38 PST 
Created attachment 303064 [details]
Patch
Comment 2 Mark Lam 2017-03-01 09:49:23 PST 
Comment on attachment 303064 [details]
Patch

r=me
Comment 3 Tomas Popela 2017-03-02 01:42:18 PST 
Comment on attachment 303064 [details]
Patch

Clearing flags on attachment: 303064

Committed r213275: <http://trac.webkit.org/changeset/213275>
Comment 4 Tomas Popela 2017-03-02 01:42:26 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-03-10 12:09:35 PST 
<rdar://problem/30978527>