Bug 169028 – [GTK] Fix problems found by Coverity scan in platform's keyboard and mouse events

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Tomas Popela]

18. webkitgtk-2.14.5/Source/WebCore/platform/gtk/PlatformMouseEventGtk.cpp:116: uninit_member: Non-static class member "m_modifierFlags" is not initialized in this constructor nor in any functions that it calls.
#   114|       else if (motion->state & GDK_BUTTON3_MASK)
#   115|           m_button = RightButton;
#   116|-> }
#   117|   }

and

12. webkitgtk-2.14.5/Source/WebCore/platform/gtk/PlatformMouseEventGtk.cpp:82: uninit_member: Non-static class member "m_modifierFlags" is not initialized in this constructor nor in any functions that it calls.
#    80|           ASSERT_NOT_REACHED();
#    81|       };
#    82|-> }
#    83|   
#    84|   PlatformMouseEvent::PlatformMouseEvent(GdkEventMotion* motion)

and

6. webkitgtk-2.14.5/Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp:590: uninit_member: Non-static class member "m_handledByInputMethod" is not initialized in this constructor nor in any functions that it calls.
#   588|       if (compositionResults.compositionUpdated())
#   589|           m_windowsVirtualKeyCode = VK_PROCESSKEY;
#   590|-> }
#   591|   
#   592|   void PlatformKeyboardEvent::disambiguateKeyDownEvent(Type type, bool backwardCompatibilityMode)

[Tomas Popela]

Created attachment 303060 [details]
Patch

[Tomas Popela]

Comment on attachment 303060 [details]
Patch

Clearing flags on attachment: 303060

Committed r213218: <http://trac.webkit.org/changeset/213218>

[Tomas Popela]

All reviewed patches have been landed.  Closing bug.

[Tomas Popela]

The original commit introduced a compiler error that I fixed in http://trac.webkit.org/changeset/213220:

[8/67] Building CXX object Source/WebCore/CMakeFiles/WebCorePlatformGTK2.dir/platform/gtk/PlatformKeyboardEventGtk.cpp.o
In file included from ../../Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp:31:0:
../../Source/WebCore/platform/PlatformKeyboardEvent.h: In constructor ‘WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent(GdkEventKey*, const WebCore::CompositionResults&)’:
../../Source/WebCore/platform/PlatformKeyboardEvent.h:186:14: warning: ‘WebCore::PlatformKeyboardEvent::m_autoRepeat’ will be initialized after [-Wreorder]
         bool m_autoRepeat;
              ^~~~~~~~~~~~
../../Source/WebCore/platform/PlatformKeyboardEvent.h:179:14: warning:   ‘bool WebCore::PlatformKeyboardEvent::m_handledByInputMethod’ [-Wreorder]
         bool m_handledByInputMethod;
              ^~~~~~~~~~~~~~~~~~~~~~
../../Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp:1261:1: warning:   when initialized here [-Wreorder]
 PlatformKeyboardEvent::PlatformKeyboardEvent(GdkEventKey* event, const CompositionResults& compositionResults)
 ^~~~~~~~~~~~~~~~~~~~~