Bug 169026 - [Win] DRT should not dispatch messages after test is done.
Summary: [Win] DRT should not dispatch messages after test is done.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-01 02:16 PST by Per Arne Vollan
Modified: 2021-01-12 04:07 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.38 KB, patch)
2017-03-01 02:29 PST, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2017-03-01 02:16:36 PST
Like on macOS, DRT on Windows should stop dispatching messages when test is done.
Comment 1 Per Arne Vollan 2017-03-01 02:29:15 PST
Created attachment 303056 [details]
Patch
Comment 2 Brent Fulgham 2017-03-01 10:01:55 PST
Comment on attachment 303056 [details]
Patch

Great catch! r=me.
Comment 3 Per Arne Vollan 2017-03-01 22:50:59 PST
Comment on attachment 303056 [details]
Patch

Thanks for reviewing!
Comment 4 WebKit Commit Bot 2017-03-01 23:19:08 PST
Comment on attachment 303056 [details]
Patch

Clearing flags on attachment: 303056

Committed r213270: <http://trac.webkit.org/changeset/213270>
Comment 5 WebKit Commit Bot 2017-03-01 23:19:13 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Fujii Hironori 2021-01-11 12:13:45 PST
Hi, Per.
What problem was fixed by this patch?
This change causes the following bug.

Bug 220450 – [Win][DumpRenderTree] ASSERT(!m_channel) failed in WebSocket::contextDestroyed
Comment 7 Per Arne Vollan 2021-01-12 04:07:15 PST
(In reply to Fujii Hironori from comment #6)
> Hi, Per.
> What problem was fixed by this patch?
> This change causes the following bug.
> 
> Bug 220450 – [Win][DumpRenderTree] ASSERT(!m_channel) failed in
> WebSocket::contextDestroyed

Hi! I believe this change was done in order to fix flakiness in the Windows test results.