Bug 169024 – REGRESSION(r213062): [SOUP] UTF-8 filename in Content-Disposition header incorrectly handled since r213062

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Carlos Garcia Campos]

This made test http/tests/download/literal-utf-8.html to start failing. The problem is that I removed the conversion made by String::fromUTF8WithLatin1Fallback that was added in r176930. I removed it because that made fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-unicode.html to timeout.

[Carlos Garcia Campos]

Created attachment 303055 [details]
Patch

[Michael Catanzaro]

Comment on attachment 303055 [details]
Patch

I don't understand it. You convert the header from UTF-8 to the internal encoding (UTF-16)... but only if it's ASCII...?

[Carlos Garcia Campos]

(In reply to comment #2)
> Comment on attachment 303055 [details]
> Patch
> 
> I don't understand it. You convert the header from UTF-8 to the internal
> encoding (UTF-16)... but only if it's ASCII...?

In r176930 ResourseResponse was changes to not apply any encoding conversion from message headers when adding them to the header map. So, we create the String with String constructor no String__fromaUTF8() so that we don't actually make any charset conversion. The header could be either utf8 or latin1, so we try to convert to utf8, only when it's not, falling back to latin1 if the conversion fails.

[Carlos Garcia Campos]

Committed r213226: <http://trac.webkit.org/changeset/213226>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 169051

[Carlos Garcia Campos]

Committed r213273: <http://trac.webkit.org/changeset/213273>