Bug 169015 - [Cocoa] Suppress font download dialog in new matching algorithm
Summary: [Cocoa] Suppress font download dialog in new matching algorithm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-28 18:36 PST by Myles C. Maxfield
Modified: 2017-04-13 12:34 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.21 KB, patch)
2017-02-28 18:37 PST, Myles C. Maxfield 		ap: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.10 MB, application/zip)
2017-02-28 19:15 PST, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2017-02-28 18:36:14 PST 
[Cocoa] Suppress font download dialog in new matching algorithm
Comment 1 Myles C. Maxfield 2017-02-28 18:37:08 PST 
Created attachment 303025 [details]
Patch
Comment 2 Build Bot 2017-02-28 19:15:41 PST 
Comment on attachment 303025 [details]
Patch

Attachment 303025 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3212340

New failing tests:
media/modern-media-controls/volume-down-support/volume-down-support.html
Comment 3 Build Bot 2017-02-28 19:15:44 PST 
Created attachment 303027 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Alexey Proskuryakov 2017-02-28 22:43:06 PST 
Comment on attachment 303025 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303025&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:954
> +            int one = 1;

also static?

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:955
> +            static NeverDestroyed<RetainPtr<CFNumberRef>> yes = adoptCF(CFNumberCreate(kCFAllocatorDefault, kCFNumberIntType, &one));

just "static CFNumberRef"
Comment 5 Myles C. Maxfield 2017-04-12 22:49:23 PDT 
Committed r215314: <http://trac.webkit.org/changeset/215314>
Comment 6 mitz 2017-04-12 22:51:51 PDT 
Comment on attachment 303025 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303025&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:957
> +            CFTypeRef values[] = { yes.get().get(), postScriptNameString.get() };

Would kCFBooleanTrue not work here?!
Comment 7 Myles C. Maxfield 2017-04-13 12:17:38 PDT 
(In reply to mitz from comment #6)
> Comment on attachment 303025 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=303025&action=review
> 
> > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:957
> > +            CFTypeRef values[] = { yes.get().get(), postScriptNameString.get() };
> 
> Would kCFBooleanTrue not work here?!

I didn't know about this! Thanks for telling me.
Comment 8 Myles C. Maxfield 2017-04-13 12:34:29 PDT 
Committed r215331: <http://trac.webkit.org/changeset/215331>