Bug 169015 – [Cocoa] Suppress font download dialog in new matching algorithm

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

[Cocoa] Suppress font download dialog in new matching algorithm

[Myles C. Maxfield]

Created attachment 303025 [details]
Patch

[Build Bot]

Comment on attachment 303025 [details]
Patch

Attachment 303025 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3212340

New failing tests:
media/modern-media-controls/volume-down-support/volume-down-support.html

[Build Bot]

Created attachment 303027 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Alexey Proskuryakov]

Comment on attachment 303025 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303025&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:954
> +            int one = 1;

also static?

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:955
> +            static NeverDestroyed<RetainPtr<CFNumberRef>> yes = adoptCF(CFNumberCreate(kCFAllocatorDefault, kCFNumberIntType, &one));

just "static CFNumberRef"

[Myles C. Maxfield]

Committed r215314: <http://trac.webkit.org/changeset/215314>

Comment on attachment 303025 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303025&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:957
> +            CFTypeRef values[] = { yes.get().get(), postScriptNameString.get() };

Would kCFBooleanTrue not work here?!

[Myles C. Maxfield]

(In reply to mitz from comment #6)
> Comment on attachment 303025 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=303025&action=review
> 
> > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:957
> > +            CFTypeRef values[] = { yes.get().get(), postScriptNameString.get() };
> 
> Would kCFBooleanTrue not work here?!

I didn't know about this! Thanks for telling me.

[Myles C. Maxfield]

Committed r215331: <http://trac.webkit.org/changeset/215331>