Bug 169014 - [MediaStream] UIClient may not be notified of capture state change when leaving a page
Summary: [MediaStream] UIClient may not be notified of capture state change when leavi...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-28 18:25 PST by Eric Carlson
Modified: 2017-03-02 10:18 PST (History)
8 users (show)

See Also:

Attachments
Proposed patch. (7.01 KB, patch)
2017-02-28 18:34 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2017-02-28 18:25:18 PST 
The UA may not be notified of the capture state change when leaving a page
Comment 1 Eric Carlson 2017-02-28 18:25:45 PST 
<rdar://problem/30632267>
Comment 2 Eric Carlson 2017-02-28 18:34:44 PST 
Created attachment 303024 [details]
Proposed patch.
Comment 3 youenn fablet 2017-02-28 19:50:28 PST 
Comment on attachment 303024 [details]
Proposed patch.

Was it also causing microphone/capture sandbox to not be revoked? If so, can we add some sort of test or additional checks for it?
What about session-like gum granting?
Comment 4 WebKit Commit Bot 2017-03-02 07:49:06 PST 
Comment on attachment 303024 [details]
Proposed patch.

Clearing flags on attachment: 303024

Committed r213281: <http://trac.webkit.org/changeset/213281>
Comment 5 WebKit Commit Bot 2017-03-02 07:49:12 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Ryan Haddad 2017-03-02 10:02:39 PST 
This change caused API test WebKit2.UserMediaBasic to time out:  https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20%28Tests%29/builds/4018
Comment 7 Ryan Haddad 2017-03-02 10:18:39 PST 
Reverted r213281 for reason:

This change caused API test WebKit2.UserMediaBasic to time out.

Committed r213287: <http://trac.webkit.org/changeset/213287>