Bug 168998 - font shorthand should accept variation values
Summary: font shorthand should accept variation values
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
Depends on:
Blocks: 162815
  Show dependency treegraph
Reported: 2017-02-28 15:49 PST by Myles C. Maxfield
Modified: 2017-03-23 16:14 PDT (History)
5 users (show)

See Also:

WIP (11.32 KB, patch)
2017-03-20 15:07 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (18.10 KB, patch)
2017-03-20 16:07 PDT, Myles C. Maxfield
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2017-02-28 15:49:19 PST
font shorthand should accept font-stretch values
Comment 1 Myles C. Maxfield 2017-02-28 23:00:21 PST
See also https://github.com/w3c/csswg-drafts/issues/515
Comment 2 Myles C. Maxfield 2017-03-20 09:27:14 PDT
Simply removing consumeFontWeightCSS21() causes these tests to fail:

+fast/parser/style-script-head-test.html	expected actual diff pretty diff	images diff (0.62%)	text image+text	pass	history
+fast/text/font-weight-parse.html	expected actual diff pretty diff		text	pass	history
+fast/text/simple-line-layout-innerText-with-newline.html		reference images diff (0.03%)	image	pass	history
+http/tests/misc/acid3.html	expected actual diff pretty diff	images diff (2.67%)	text image+text	pass	history
Comment 3 Myles C. Maxfield 2017-03-20 15:07:32 PDT
Created attachment 304955 [details]
Comment 4 Myles C. Maxfield 2017-03-20 16:07:22 PDT
Created attachment 304961 [details]
Comment 5 Simon Fraser (smfr) 2017-03-22 15:54:42 PDT
Comment on attachment 304961 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=304961&action=review

> Source/WebCore/ChangeLog:12
> +        accepts percentages, which are also accepted by font-size, which means those can't

"those" here is ambiguous.

> Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:202
> +    // Values less than or equal to 0 or greater than or equal to 1000 are parse errors.

Is this covered in the testing?
Comment 6 Myles C. Maxfield 2017-03-23 16:14:07 PDT
Committed r214324: <http://trac.webkit.org/changeset/214324>