Bug 168996 – Change JSLock to stash PlatformThread instead of std::thread::id.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

PlatformThread is more useful because it allows us to:
1. suspend / resume threads.
2. find the MachineThreads::Thread which is associated with it.
3. send a signal to the thread.

[Mark Lam]

Created attachment 303005 [details]
proposed patch.

Let's test this on the EWS.

[Mark Lam]

Comment on attachment 303005 [details]
proposed patch.

Thanks for the review.

[WebKit Commit Bot]

Comment on attachment 303005 [details]
proposed patch.

Clearing flags on attachment: 303005

Committed r213202: <http://trac.webkit.org/changeset/213202>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Mark Lam]

The patch has been rolled out in r213231: <http://trac.webkit.org/r213231>.

[Mark Lam]

Created attachment 303087 [details]
proposed patch.

[Saam Barati]

Comment on attachment 303087 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=303087&action=review

r=me

> Source/JavaScriptCore/runtime/JSLock.cpp:173
> +        WTF::storeStoreFence();

This isn't necessary

> Source/JavaScriptCore/runtime/JSLock.h:96
> +    std::optional<PlatformThread> ownerThread() const { return m_ownerThread; }

you need to do the right thing here by checking m_hasOwnerThread

[Mark Lam]

Comment on attachment 303087 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=303087&action=review

Thanks for the review.

>> Source/JavaScriptCore/runtime/JSLock.cpp:173
>> +        WTF::storeStoreFence();
> 
> This isn't necessary

I've removed this.

>> Source/JavaScriptCore/runtime/JSLock.h:96
>> +    std::optional<PlatformThread> ownerThread() const { return m_ownerThread; }
> 
> you need to do the right thing here by checking m_hasOwnerThread

Fixed.

[Mark Lam]

Created attachment 303092 [details]
patch for landing.

[Mark Lam]

Created attachment 303095 [details]
patch for landing: added a comment in JSLock to explain why m_ownerThread cannot be an optional.

[Mark Lam]

Thanks for the review.  Landed in r213238: <http://trac.webkit.org/r213238>.