Bug 168990 – [WebRTC] CPU Overuse libwebrtc detector is decreasing the quality of the video

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

For now, we can just disable it.
We should at the end investigate the different strategies in that case.

[youenn fablet]

Created attachment 302986 [details]
Patch

[Eric Carlson]

Comment on attachment 302986 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302986&action=review

> Source/ThirdParty/libwebrtc/ChangeLog:4
> +        Fix 168990
> +

Nit: this isn't necessary.

> Source/ThirdParty/libwebrtc/Source/webrtc/video/vie_encoder.cc:791
> +  //WEBKIT Change: We disable OveruseDetected for now.

Nit: space after the "//"

[youenn fablet]

Created attachment 302994 [details]
Patch for landing

[youenn fablet]

Thanks for the review.

(In reply to comment #2)
> Comment on attachment 302986 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=302986&action=review
> 
> > Source/ThirdParty/libwebrtc/ChangeLog:4
> > +        Fix 168990
> > +
> 
> Nit: this isn't necessary.

OK

> > Source/ThirdParty/libwebrtc/Source/webrtc/video/vie_encoder.cc:791
> > +  //WEBKIT Change: We disable OveruseDetected for now.
> 
> Nit: space after the "//"

Done

[WebKit Commit Bot]

Comment on attachment 302994 [details]
Patch for landing

Clearing flags on attachment: 302994

Committed r213184: <http://trac.webkit.org/changeset/213184>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.