Bug 168988 - Make the repaint indicators show subpixel antialiased text indication a bit more clearly
Summary: Make the repaint indicators show subpixel antialiased text indication a bit m...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-28 14:12 PST by Simon Fraser (smfr)
Modified: 2017-03-01 09:52 PST (History)
2 users (show)

See Also:

Attachments
Patch (7.23 KB, patch)
2017-02-28 14:13 PST, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-02-28 14:12:46 PST 
Make the repaint indicators show subpixel antialiased text indication a bit more clearly
Comment 1 Simon Fraser (smfr) 2017-02-28 14:13:26 PST 
Created attachment 302984 [details]
Patch
Comment 2 Simon Fraser (smfr) 2017-02-28 16:22:52 PST 
https://trac.webkit.org/changeset/213191
Comment 3 Ryan Haddad 2017-03-01 09:32:23 PST 
This change broke the Windows build:

C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\graphics\ca\PlatformCALayer.cpp(152): error C2065: 'kCTStrokeWidthAttributeName': undeclared identifier [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\graphics\ca\PlatformCALayer.cpp(153): error C2065: 'kCTStrokeColorAttributeName': undeclared identifier [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]

https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/84383
Comment 4 Simon Fraser (smfr) 2017-03-01 09:35:46 PST 
EWS was missing.
Comment 5 Simon Fraser (smfr) 2017-03-01 09:49:37 PST 
Fixing.
Comment 6 Simon Fraser (smfr) 2017-03-01 09:52:25 PST 
Hopefully fixed in https://trac.webkit.org/r213227