Bug 168986 - LibWebRTCProvider should check existence of libwebrtc.dylib
Summary: LibWebRTCProvider should check existence of libwebrtc.dylib
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-28 13:36 PST by Alex Christensen
Modified: 2017-02-28 16:09 PST (History)
0 users

See Also:

Attachments
Patch (14.18 KB, patch)
2017-02-28 13:40 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (14.00 KB, patch)
2017-02-28 15:01 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (14.62 KB, patch)
2017-02-28 15:11 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (15.17 KB, patch)
2017-02-28 15:19 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-02-28 13:36:17 PST 
LibWebRTCProvider should check existence of libwebrtc.dylib
Comment 1 Alex Christensen 2017-02-28 13:40:52 PST 
Created attachment 302975 [details]
Patch
Comment 2 youenn fablet 2017-02-28 14:14:15 PST 
Comment on attachment 302975 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302975&action=review

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:160
> +    if (senders.size() && LibWebRTCProvider::factory()) {

If we do not have a factory, it might be better to just reject the promise upfront.
Typically by calling createOfferFailed from m_peerConnectionBackend.
Comment 3 Alex Christensen 2017-02-28 15:01:23 PST 
Created attachment 302991 [details]
Patch
Comment 4 Alex Christensen 2017-02-28 15:11:10 PST 
Created attachment 302995 [details]
Patch
Comment 5 Alex Christensen 2017-02-28 15:19:57 PST 
Created attachment 302996 [details]
Patch
Comment 6 Alex Christensen 2017-02-28 16:09:27 PST 
http://trac.webkit.org/r213190