Bug 168979 – Add ability for webkitpy to run bindings tests

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Srinivasan Vijayaraghavan]

Add ability for webkitpy to run bindings tests

[Srinivasan Vijayaraghavan]

Created attachment 302955 [details]
Patch

[Aakash Jain]

Comment on attachment 302955 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302955&action=review

looks good to me.

> Tools/Scripts/webkitpy/tool/steps/runtests.py:168
> +        self._tool.filesystem.maybe_make_directory(results_directory)

do we need similar line in _run_javascriptcore_tests as well above.

[Srinivasan Vijayaraghavan]

(In reply to comment #2)
> Comment on attachment 302955 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=302955&action=review
> 
> looks good to me.
> 
> > Tools/Scripts/webkitpy/tool/steps/runtests.py:168
> > +        self._tool.filesystem.maybe_make_directory(results_directory)
> 
> do we need similar line in _run_javascriptcore_tests as well above.

JSC tests cannot run without building, so if the WebKitBuild/[Release/Debug] directory doesn't exist at the time of writing the test results to a file, something would have gone very wrong.

Adding the line enables some code to be abstracted out, but I'd prefer to not abstract things out until we have another group of tests.

Some things, like the results directory, might change by then. Placing results inside WebKitBuild/ for consistency is OK, but it might make sense to move as we add more tests that don't require a build to run (bindings is one of them, also webkitpy, webkitperl etc).

[Srinivasan Vijayaraghavan]

Created attachment 302982 [details]
Patch

[Srinivasan Vijayaraghavan]

Added a unit test.

[Aakash Jain]

looks good to me.

[WebKit Commit Bot]

Comment on attachment 302982 [details]
Patch

Clearing flags on attachment: 302982

Committed r213185: <http://trac.webkit.org/changeset/213185>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.