RESOLVED FIXED 168977
Remove setExclusiveThread() and peers from the JSLock.
https://bugs.webkit.org/show_bug.cgi?id=168977
Summary Remove setExclusiveThread() and peers from the JSLock.
Mark Lam
Reported 2017-02-28 10:52:02 PST
JSLock::setExclusiveThread() was only used by WebCore. Benchmarking with Speedometer, we see that removal of exclusive thread status has no measurable impact on performance. So, let's remove the code for handling exclusive thread status, and simplify the JSLock code.
Attachments
proposed patch. (9.19 KB, patch)
2017-02-28 11:05 PST, Mark Lam
mark.lam: review-
proposed patch. (9.18 KB, patch)
2017-02-28 11:10 PST, Mark Lam
no flags
proposed patch. (11.26 KB, patch)
2017-02-28 11:44 PST, Mark Lam
no flags
Mark Lam
Comment 1 2017-02-28 11:05:26 PST
Created attachment 302951 [details] proposed patch. Let's get some EWS testing.
Mark Lam
Comment 2 2017-02-28 11:10:14 PST
Created attachment 302952 [details] proposed patch.
Mark Lam
Comment 3 2017-02-28 11:44:25 PST
Created attachment 302957 [details] proposed patch.
Mark Lam
Comment 4 2017-02-28 13:00:25 PST
Comment on attachment 302957 [details] proposed patch. Time for a review.
Mark Lam
Comment 5 2017-02-28 13:24:00 PST
Comment on attachment 302957 [details] proposed patch. Thanks for the review.
WebKit Commit Bot
Comment 6 2017-02-28 13:58:38 PST
Comment on attachment 302957 [details] proposed patch. Clearing flags on attachment: 302957 Committed r213175: <http://trac.webkit.org/changeset/213175>
WebKit Commit Bot
Comment 7 2017-02-28 13:58:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.