Bug 168977 - Remove setExclusiveThread() and peers from the JSLock.
Summary: Remove setExclusiveThread() and peers from the JSLock.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-28 10:52 PST by Mark Lam
Modified: 2017-02-28 13:58 PST (History)
7 users (show)

See Also:

Attachments
proposed patch. (9.19 KB, patch)
2017-02-28 11:05 PST, Mark Lam 		mark.lam: review-
Details | Formatted Diff | Diff
proposed patch. (9.18 KB, patch)
2017-02-28 11:10 PST, Mark Lam 		no flags Details | Formatted Diff | Diff
proposed patch. (11.26 KB, patch)
2017-02-28 11:44 PST, Mark Lam 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2017-02-28 10:52:02 PST 
JSLock::setExclusiveThread() was only used by WebCore.  Benchmarking with Speedometer, we see that removal of exclusive thread status has no measurable impact on performance.  So, let's remove the code for handling exclusive thread status, and simplify the JSLock code.
Comment 1 Mark Lam 2017-02-28 11:05:26 PST 
Created attachment 302951 [details]
proposed patch.

Let's get some EWS testing.
Comment 2 Mark Lam 2017-02-28 11:10:14 PST 
Created attachment 302952 [details]
proposed patch.
Comment 3 Mark Lam 2017-02-28 11:44:25 PST 
Created attachment 302957 [details]
proposed patch.
Comment 4 Mark Lam 2017-02-28 13:00:25 PST 
Comment on attachment 302957 [details]
proposed patch.

Time for a review.
Comment 5 Mark Lam 2017-02-28 13:24:00 PST 
Comment on attachment 302957 [details]
proposed patch.

Thanks for the review.
Comment 6 WebKit Commit Bot 2017-02-28 13:58:38 PST 
Comment on attachment 302957 [details]
proposed patch.

Clearing flags on attachment: 302957

Committed r213175: <http://trac.webkit.org/changeset/213175>
Comment 7 WebKit Commit Bot 2017-02-28 13:58:42 PST 
All reviewed patches have been landed.  Closing bug.