Bug 168976 - Web Inspector: It is possible to get the New Tab button in addition to the seven expected tabs
Summary: Web Inspector: It is possible to get the New Tab button in addition to the se...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-28 10:50 PST by BJ Burg
Modified: 2017-02-28 15:36 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.91 KB, patch)
2017-02-28 13:59 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2017-02-28 10:50:07 PST 
(via Nelson Thachuk:)

* SUMMARY
- It is possible to get the New Tab button in addition to the seven expected tabs

* STEPS TO REPRODUCE
1. Launch Safari
2. Navigate to a webpage
3. Show Web Inspector (⌥⌘I)
4. Open all Web Inspector tabs
5. Close the Console tab
6. Click the New Tab button
7. From any tab, enter something in to the Console at the bottom of the tab
8. Click the “Show console tab” button (if required by the current tab)

* EXPECTED RESULTS
- New Tab tab should be replaced with Console tab

* ACTUAL RESULTS
- New Tab tab and Console tab coexist
- New Tab tab has no functionality since no tabs can be opened
- New Tab tab cannot be closed
- Close button for all other tabs moves from expected location to on top of the glyph representing the tab
Comment 1 BJ Burg 2017-02-28 10:50:31 PST 
<rdar://problem/30621630>
Comment 2 Devin Rousso 2017-02-28 11:35:14 PST 
I feel like a simple solution to this would be to just let the user close the New Tab tab.  I will often accidentally click it and it's very annoying to have to open Storage and then close it immediately thereafter.
Comment 3 Joseph Pecoraro 2017-02-28 12:10:29 PST 
(In reply to comment #2)
> I feel like a simple solution to this would be to just let the user close
> the New Tab tab.  I will often accidentally click it and it's very annoying
> to have to open Storage and then close it immediately thereafter.

Yeah that sounds good.
Comment 4 Devin Rousso 2017-02-28 13:59:13 PST 
Created attachment 302983 [details]
Patch
Comment 5 BJ Burg 2017-02-28 14:16:46 PST 
Comment on attachment 302983 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2017-02-28 15:36:15 PST 
Comment on attachment 302983 [details]
Patch

Clearing flags on attachment: 302983

Committed r213188: <http://trac.webkit.org/changeset/213188>
Comment 7 WebKit Commit Bot 2017-02-28 15:36:20 PST 
All reviewed patches have been landed.  Closing bug.