Bug 168973 - [WebRTC] LibWebRTC frame dropper is not working consistently
Summary: [WebRTC] LibWebRTC frame dropper is not working consistently
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-28 09:16 PST by youenn fablet
Modified: 2017-02-28 11:15 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.09 KB, patch)
2017-02-28 09:19 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (2.24 KB, patch)
2017-02-28 10:35 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-02-28 09:16:18 PST 
It is sometimes dropping frames while there is no need.
Comment 1 youenn fablet 2017-02-28 09:19:29 PST 
Created attachment 302939 [details]
Patch
Comment 2 youenn fablet 2017-02-28 09:20:42 PST 
(In reply to comment #1)
> Created attachment 302939 [details]
> Patch

This patch disables the frame dropper optimizer for now.
We should investigate it further, probably after migrating to a more recent libwebrtc revision.
Comment 3 Eric Carlson 2017-02-28 09:27:24 PST 
Comment on attachment 302939 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302939&action=review

> Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/video_sender.cc:117
> +  // FIXME: Investigate why and enable it again.

Nit: please add a bug number here.
Comment 4 youenn fablet 2017-02-28 10:35:05 PST 
Created attachment 302948 [details]
Patch for landing
Comment 5 youenn fablet 2017-02-28 10:36:39 PST 
Thanks for the review.

(In reply to comment #3)
> Comment on attachment 302939 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=302939&action=review
> 
> > Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/video_sender.cc:117
> > +  // FIXME: Investigate why and enable it again.
> 
> Nit: please add a bug number here.

Let's use this one. I'll reopen this bug once this patch got landed.
Comment 6 WebKit Commit Bot 2017-02-28 11:15:08 PST 
Comment on attachment 302948 [details]
Patch for landing

Clearing flags on attachment: 302948

Committed r213152: <http://trac.webkit.org/changeset/213152>
Comment 7 WebKit Commit Bot 2017-02-28 11:15:14 PST 
All reviewed patches have been landed.  Closing bug.