RESOLVED FIXED 168959
Calling build() on a baseline point results in an exception 
https://bugs.webkit.org/show_bug.cgi?id=168959
Summary Calling build() on a baseline point results in an exception
Ryosuke Niwa
Reported 2017-02-27 20:00:12 PST
build() function on a point object returned by MeasurementAdaptor must return null when the builder id is not available instead of throwing.
Attachments
Fixes the bug (4.23 KB, patch)
2017-02-27 20:02 PST, Ryosuke Niwa 		joepeck: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2017-02-27 20:02:29 PST
Created attachment 302916 [details] Fixes the bug
Joseph Pecoraro
Comment 2 2017-02-27 20:05:54 PST
Comment on attachment 302916 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=302916&action=review rs=me > Websites/perf.webkit.org/unit-tests/measurement-adaptor-tests.js:65 > + it('should adapt build information as null when the builder is not specified', function () { > + var adoptor = new MeasurementAdaptor(sampleCluster.formatMap); Is this code adopting or adapting? (Same comment applies to surrounding code).
Ryosuke Niwa
Comment 3 2017-02-27 20:08:56 PST
Committed r213117: <http://trac.webkit.org/changeset/213117>
Note You need to log in before you can comment on or make changes to this bug.