Bug 168958 - [Modern Media Controls] Use compact mode by default on macOS
Summary: [Modern Media Controls] Use compact mode by default on macOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-27 18:25 PST by Antoine Quint
Modified: 2017-02-27 19:26 PST (History)
4 users (show)

See Also:


Attachments
Patch (27.71 KB, patch)
2017-02-27 18:32 PST, Antoine Quint
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-elcapitan (1.09 MB, application/zip)
2017-02-27 19:17 PST, Build Bot
no flags Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.09 MB, application/zip)
2017-02-27 19:19 PST, Build Bot
no flags Details
Patch for landing (28.61 KB, patch)
2017-02-27 19:25 PST, Antoine Quint
graouts: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2017-02-27 18:25:42 PST
Larger controls on macOS have proven to be an issue. Until we resolve some of the UI issues, let's use the compact mode as the only supported mode for inline media controls.
Comment 1 Radar WebKit Bug Importer 2017-02-27 18:25:57 PST
<rdar://problem/30748638>
Comment 2 Antoine Quint 2017-02-27 18:32:11 PST
Created attachment 302909 [details]
Patch
Comment 3 Jon Lee 2017-02-27 18:39:36 PST
Comment on attachment 302909 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302909&action=review

> Source/WebCore/Modules/modern-media-controls/controls/scrubber.js:63
> +        this.height = (this.layoutTraits & LayoutTraits.Compact) ? 15 : 23; 

would prefer to see these as constants instead.
Comment 4 Build Bot 2017-02-27 19:17:43 PST
Comment on attachment 302909 [details]
Patch

Attachment 302909 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3205940

New failing tests:
media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-tight-padding.html
Comment 5 Build Bot 2017-02-27 19:17:46 PST
Created attachment 302910 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-02-27 19:18:59 PST
Comment on attachment 302909 [details]
Patch

Attachment 302909 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3205938

New failing tests:
media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-tight-padding.html
Comment 7 Build Bot 2017-02-27 19:19:03 PST
Created attachment 302911 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 8 Antoine Quint 2017-02-27 19:25:46 PST
Created attachment 302912 [details]
Patch for landing
Comment 9 Antoine Quint 2017-02-27 19:26:34 PST
Committed r213115: <http://trac.webkit.org/changeset/213115>