Bug 168958 – [Modern Media Controls] Use compact mode by default on macOS

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Antoine Quint]

Larger controls on macOS have proven to be an issue. Until we resolve some of the UI issues, let's use the compact mode as the only supported mode for inline media controls.

[Radar WebKit Bug Importer]

<rdar://problem/30748638>

[Antoine Quint]

Created attachment 302909 [details]
Patch

[Jon Lee]

Comment on attachment 302909 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302909&action=review

> Source/WebCore/Modules/modern-media-controls/controls/scrubber.js:63
> +        this.height = (this.layoutTraits & LayoutTraits.Compact) ? 15 : 23; 

would prefer to see these as constants instead.

[Build Bot]

Comment on attachment 302909 [details]
Patch

Attachment 302909 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3205940

New failing tests:
media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-tight-padding.html

[Build Bot]

Created attachment 302910 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 302909 [details]
Patch

Attachment 302909 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3205938

New failing tests:
media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-tight-padding.html

[Build Bot]

Created attachment 302911 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Antoine Quint]

Created attachment 302912 [details]
Patch for landing

[Antoine Quint]

Committed r213115: <http://trac.webkit.org/changeset/213115>