WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
168955
Expose _WKVisitedLinkProvider in a header
https://bugs.webkit.org/show_bug.cgi?id=168955
Summary
Expose _WKVisitedLinkProvider in a header
Alexey Proskuryakov
Reported
2017-02-27 17:52:29 PST
_WKVisitedLinkProvider should be in a header, because it is exported.
Attachments
proposed patch
(1.77 KB, patch)
2017-02-27 17:55 PST
,
Alexey Proskuryakov
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2017-02-27 17:55:06 PST
Created
attachment 302903
[details]
proposed patch
Aakash Jain
Comment 2
2017-02-27 18:01:53 PST
Comment on
attachment 302903
[details]
proposed patch View in context:
https://bugs.webkit.org/attachment.cgi?id=302903&action=review
overall looks good to me.
> Source/WebKit2/UIProcess/API/Cocoa/_WKVisitedLinkStore.h:40 > +__attribute__((visibility("default"))) NS_UNAVAILABLE
why do we need NS_UNAVAILABLE?
Alexey Proskuryakov
Comment 3
2017-02-28 16:37:36 PST
We don't want any new clients to use this function, it is only for binary compatibility.
WebKit Commit Bot
Comment 4
2017-02-28 17:05:54 PST
Comment on
attachment 302903
[details]
proposed patch Clearing flags on attachment: 302903 Committed
r213195
: <
http://trac.webkit.org/changeset/213195
>
WebKit Commit Bot
Comment 5
2017-02-28 17:05:57 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug