Bug 168955 - Expose _WKVisitedLinkProvider in a header
Summary: Expose _WKVisitedLinkProvider in a header
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-27 17:52 PST by Alexey Proskuryakov
Modified: 2017-02-28 17:05 PST (History)
3 users (show)

See Also:

Attachments
proposed patch (1.77 KB, patch)
2017-02-27 17:55 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2017-02-27 17:52:29 PST 
_WKVisitedLinkProvider should be in a header, because it is exported.
Comment 1 Alexey Proskuryakov 2017-02-27 17:55:06 PST 
Created attachment 302903 [details]
proposed patch
Comment 2 Aakash Jain 2017-02-27 18:01:53 PST 
Comment on attachment 302903 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302903&action=review

overall looks good to me.

> Source/WebKit2/UIProcess/API/Cocoa/_WKVisitedLinkStore.h:40
> +__attribute__((visibility("default"))) NS_UNAVAILABLE

why do we need NS_UNAVAILABLE?
Comment 3 Alexey Proskuryakov 2017-02-28 16:37:36 PST 
We don't want any new clients to use this function, it is only for binary compatibility.
Comment 4 WebKit Commit Bot 2017-02-28 17:05:54 PST 
Comment on attachment 302903 [details]
proposed patch

Clearing flags on attachment: 302903

Committed r213195: <http://trac.webkit.org/changeset/213195>
Comment 5 WebKit Commit Bot 2017-02-28 17:05:57 PST 
All reviewed patches have been landed.  Closing bug.