Bug 168952 - WKPageIsPlayingVideoInEnhancedFullscreen availability mismatch
Summary: WKPageIsPlayingVideoInEnhancedFullscreen availability mismatch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-27 17:19 PST by Alexey Proskuryakov
Modified: 2017-02-27 18:10 PST (History)
4 users (show)

See Also:

Attachments
proposed patch (1.20 KB, patch)
2017-02-27 17:21 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2017-02-27 17:19:05 PST 
WKPageIsPlayingVideoInEnhancedFullscreen is declared for macOS and iOS, but it is only implemented for macOS.

The reason is that TARGET_OS_MAC is true for both.
Comment 1 Alexey Proskuryakov 2017-02-27 17:21:00 PST 
Created attachment 302898 [details]
proposed patch
Comment 2 Aakash Jain 2017-02-27 17:26:31 PST 
unofficial r+.
Comment 3 WebKit Commit Bot 2017-02-27 18:10:17 PST 
Comment on attachment 302898 [details]
proposed patch

Clearing flags on attachment: 302898

Committed r213112: <http://trac.webkit.org/changeset/213112>
Comment 4 WebKit Commit Bot 2017-02-27 18:10:21 PST 
All reviewed patches have been landed.  Closing bug.