Bug 168941 - [Modern Media Controls] Use a solid background for <audio> controls on macOS
Summary: [Modern Media Controls] Use a solid background for <audio> controls on macOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-27 15:31 PST by Antoine Quint
Modified: 2017-02-27 17:22 PST (History)
3 users (show)

See Also:

Attachments
Patch (5.43 KB, patch)
2017-02-27 15:33 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch for landing (2.55 KB, patch)
2017-02-27 17:18 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2017-02-27 15:31:35 PST 
We should not use a background tint on macOS, but rather a solid fill.
Comment 1 Radar WebKit Bug Importer 2017-02-27 15:31:51 PST 
<rdar://problem/30744316>
Comment 2 Antoine Quint 2017-02-27 15:33:15 PST 
Created attachment 302877 [details]
Patch
Comment 3 WebKit Commit Bot 2017-02-27 16:03:20 PST 
Comment on attachment 302877 [details]
Patch

Clearing flags on attachment: 302877

Committed r213099: <http://trac.webkit.org/changeset/213099>
Comment 4 WebKit Commit Bot 2017-02-27 16:03:24 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Ryan Haddad 2017-02-27 16:57:03 PST 
The LayoutTest for this change is failing on iOS: https://build.webkit.org/results/Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/r213099%20(4127)/results.html

It looks like ios-sim EWS caught this before the patch as landed.
Comment 6 Antoine Quint 2017-02-27 17:11:49 PST 
Thanks Ryan, I'll fix this once I'm done building iOS.
Comment 7 Antoine Quint 2017-02-27 17:18:19 PST 
Reopening to attach new patch.
Comment 8 Antoine Quint 2017-02-27 17:18:21 PST 
Created attachment 302897 [details]
Patch for landing
Comment 9 Ryan Haddad 2017-02-27 17:22:09 PST 
Comment on attachment 302897 [details]
Patch for landing

Clearing flags on attachment: 302897

Committed r213106: <http://trac.webkit.org/changeset/213106>
Comment 10 Ryan Haddad 2017-02-27 17:22:13 PST 
All reviewed patches have been landed.  Closing bug.