Bug 168940 - [iOS] Getting QLPreviewProtocol slows down first navigation in Web process
Summary: [iOS] Getting QLPreviewProtocol slows down first navigation in Web process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
: 168993 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-02-27 15:15 PST by mitz
Modified: 2017-02-28 15:23 PST (History)
9 users (show)

See Also:

Attachments
Patch (7.10 KB, patch)
2017-02-28 15:07 PST, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2017-02-27 15:15:43 PST 
The first navigation in a Web process is slowed down checking if the protocol is QLPreviewProtocol, which involves dynamically loading Quick Look. This can be avoided for common schemes.
Comment 1 Tim Horton 2017-02-28 15:05:25 PST 
*** Bug 168993 has been marked as a duplicate of this bug. ***
Comment 2 Tim Horton 2017-02-28 15:07:11 PST 
Created attachment 302993 [details]
Patch
Comment 3 Tim Horton 2017-02-28 15:07:35 PST 
rdar://problem/29468999
Comment 4 Simon Fraser (smfr) 2017-02-28 15:15:28 PST 
Comment on attachment 302993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302993&action=review

> Source/WebCore/loader/ios/QuickLook.mm:130
> +        return NO;

NO!