LayoutTest media/modern-media-controls/volume-down-support/volume-down-support.html is flaky https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r213089%20(4021)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fvolume-down-support%2Fvolume-down-support.html It looks like this test is frequently timing out or failing on macOS. Here is the diff from the most recent failure: --- /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/media/modern-media-controls/volume-down-support/volume-down-support-expected.txt +++ /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/media/modern-media-controls/volume-down-support/volume-down-support-actual.txt @@ -6,7 +6,7 @@ PASS media.volume is 1 Pressing on the volume down button -PASS media.volume is 0 +FAIL media.volume should be 0. Was 0.009. PASS successfullyParsed is true
This one seems to be affecting EWS results.
<rdar://problem/30796699>
Created attachment 303153 [details] Patch
Comment on attachment 303153 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303153&action=review > LayoutTests/ChangeLog:11 > + Use asynchronous assertions to guarantee we've entered fullscreen and the volume down button > + is present and leave a little room for error when checking the volume since we would sometime > + see a value of 0.009 rather than 0. This is a long sentence. Why do we see this value? > LayoutTests/media/modern-media-controls/volume-down-support/volume-down-support.html:25 > + shouldBeCloseTo("media.volume", 0, 0.1); Maybe add a comment explaining why the fudge factor.
Comment on attachment 303153 [details] Patch Clearing flags on attachment: 303153 Committed r213258: <http://trac.webkit.org/changeset/213258>
All reviewed patches have been landed. Closing bug.