Bug 168935 - LayoutTest media/modern-media-controls/volume-down-support/volume-down-support.html is flaky
Summary: LayoutTest media/modern-media-controls/volume-down-support/volume-down-suppor...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-27 14:29 PST by Ryan Haddad
Modified: 2017-03-01 19:45 PST (History)
4 users (show)

See Also:


Attachments
Patch (4.81 KB, patch)
2017-03-01 18:06 PST, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2017-02-27 14:29:38 PST
LayoutTest media/modern-media-controls/volume-down-support/volume-down-support.html is flaky

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r213089%20(4021)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fvolume-down-support%2Fvolume-down-support.html

It looks like this test is frequently timing out or failing on macOS. Here is the diff from the most recent failure:

--- /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/media/modern-media-controls/volume-down-support/volume-down-support-expected.txt
+++ /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/media/modern-media-controls/volume-down-support/volume-down-support-actual.txt
@@ -6,7 +6,7 @@
 PASS media.volume is 1
 
 Pressing on the volume down button
-PASS media.volume is 0
+FAIL media.volume should be 0. Was 0.009.
 
 PASS successfullyParsed is true
Comment 1 Ryan Haddad 2017-02-27 14:31:33 PST
This one seems to be affecting EWS results.
Comment 2 Radar WebKit Bug Importer 2017-03-01 17:39:27 PST
<rdar://problem/30796699>
Comment 3 Antoine Quint 2017-03-01 18:06:42 PST
Created attachment 303153 [details]
Patch
Comment 4 Dean Jackson 2017-03-01 19:17:40 PST
Comment on attachment 303153 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303153&action=review

> LayoutTests/ChangeLog:11
> +        Use asynchronous assertions to guarantee we've entered fullscreen and the volume down button
> +        is present and leave a little room for error when checking the volume since we would sometime
> +        see a value of 0.009 rather than 0.

This is a long sentence. Why do we see this value?

> LayoutTests/media/modern-media-controls/volume-down-support/volume-down-support.html:25
> +            shouldBeCloseTo("media.volume", 0, 0.1);

Maybe add a comment explaining why the fudge factor.
Comment 5 WebKit Commit Bot 2017-03-01 19:44:57 PST
Comment on attachment 303153 [details]
Patch

Clearing flags on attachment: 303153

Committed r213258: <http://trac.webkit.org/changeset/213258>
Comment 6 WebKit Commit Bot 2017-03-01 19:45:02 PST
All reviewed patches have been landed.  Closing bug.