Bug 168928 - [Win] REGRESSION(r211254): IWebPreferencesPrivate binary API broken
Summary: [Win] REGRESSION(r211254): IWebPreferencesPrivate binary API broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on: 167421
Blocks:
  Show dependency treegraph
 
Reported: 2017-02-27 13:44 PST by Brent Fulgham
Modified: 2017-03-15 09:19 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.88 KB, patch)
2017-02-28 09:23 PST, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (3.52 KB, patch)
2017-02-28 09:41 PST, Per Arne Vollan
bfulgham: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2017-02-27 13:44:53 PST
Two new methods were injected into the existing IWebPreferencesPrivate interface, breaking binary API compatibility.

We need to create a new IWebPreferencesPrivate5 interface holding these two new methods.
Comment 1 Brent Fulgham 2017-02-27 13:45:56 PST
<rdar://problem/30687449>
Comment 2 Per Arne Vollan 2017-02-27 23:09:23 PST
It seems these methods were removed again in <http://trac.webkit.org/changeset/212173>.
Comment 3 Per Arne Vollan 2017-02-28 09:23:06 PST
Created attachment 302940 [details]
Patch
Comment 4 Per Arne Vollan 2017-02-28 09:41:08 PST
Created attachment 302942 [details]
Patch
Comment 5 Brent Fulgham 2017-02-28 10:50:50 PST
Comment on attachment 302942 [details]
Patch

R=me
Comment 6 Brent Fulgham 2017-02-28 10:52:01 PST
I think this is only relevant to the branch where this code is still present.
Comment 7 Brent Fulgham 2017-03-15 09:19:43 PDT
This was a branch-specific change.